Coder Social home page Coder Social logo

Comments (11)

rhysd avatar rhysd commented on August 22, 2024

Yes, there is no way to modify arguments passed to shellcheck. What arguments do you want to pass and can I ask the reason?

from actionlint.

nijel avatar nijel commented on August 22, 2024

I need to disable SC2046 as nested function generates command line parameters, and we need word splitting there.

from actionlint.

nijel avatar nijel commented on August 22, 2024

The best solution would be to disable it per command (something like https://github.com/koalaman/shellcheck/wiki/Ignore#ignoring-one-specific-instance-in-a-file), but having a global override would be good enough.

from actionlint.

rhysd avatar rhysd commented on August 22, 2024

I don't think SC2046 should be always suppressed. But as the document says, it has some rare case where it should be ignored.

I'll consider to override shellcheck arguments by options.

from actionlint.

rhysd avatar rhysd commented on August 22, 2024

@nijel Before considering the details of the feature, I want to confirm one thing.

Is -ignore option sufficient for your use case?

actionlint -ignore 'SC2046:'

from actionlint.

nijel avatar nijel commented on August 22, 2024

We currently use actionlint via GitHub super-linter and that doesn't seem to support passing command line parameters, it can only use the configuration file.

from actionlint.

rhysd avatar rhysd commented on August 22, 2024

that doesn't seem to support passing command line parameters

That sounds a problem of super-linter. Can we improve super-linter side? I'll take a look at the repo later.

from actionlint.

nijel avatar nijel commented on August 22, 2024

All other linters use configuration files, what is really preferred way - the configuration sits in the repository and you can run linter without any parameters.

from actionlint.

rhysd avatar rhysd commented on August 22, 2024

OK, I understood the situation. I'll consider how to handle this.

from actionlint.

rhysd avatar rhysd commented on August 22, 2024

I have made PR at super-linter, which allows to pass additional command line options through an environment variable.

github/super-linter#1853

Let's see if this is merged.

from actionlint.

rhysd avatar rhysd commented on August 22, 2024

This is not an issue of actionlint and will be fixed github/super-linter#1667. Please comment there.

from actionlint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.