Comments (4)
So basically givemon
always gives either a shiny mon or a regular one? And we would like a third random option? It could work, so that 0 - always normal, 1 - always shiny and any other value would be random. Does that sound good?
from pokeemerald-expansion.
So basically givemon always gives either a shiny mon or a regular one?
Correct
And we would like a third random option?
The issue is that the shininess became a locked value due to givemon
being reimplemented from a debugging perspective, rather than the almost exclusively vanilla case where shininess is regularly left over to the RNG. I would personally go as far as vouching that the default value (i.e. 0) should cause a random roll and that other values (1 and 2, presumably) would result into either locking it as shiny or non-shiny
from pokeemerald-expansion.
I think #2806 might address givemon
: https://github.com/rh-hideout/pokeemerald-expansion/pull/2806/files#diff-dcf69379dc1632054ee142ffde1654c1c89bd7d709495e2533c749691c088cd0R449
from pokeemerald-expansion.
Then it definitely needs to be reviewed, haha
from pokeemerald-expansion.
Related Issues (20)
- Octolock and Coil move descriptions
- Test runner Level macro overwrites other stats macros
- Test runner throws "Illegal MOVE" when battler do more moves than the amount available in their level up moveset
- Upper Hand being used when it shouldn't
- U-Turn With Ace Mon HOT 1
- New flag for pokemon in trainer_parties HOT 2
- If the Pokemon don't obedience sometimes move background scrolling won't end
- Terastallization does not grant immunity to tar shot
- Can't use #define-d constants in event.inc macros
- Hidden Ability Patches HOT 10
- PNG validator and fixer for pngs in the expansion HOT 1
- Reminder: Fix sprite follower elevation regression
- Using a debug menu script freezes followers HOT 1
- Mega Evolution-related softlock
- Reminder: Incorporate trainers.party documentation by Hedara
- Aegislash becoming Blade Forme at the end of battle
- Blank name in naming screen sets Pokémon’s nickname to species name, stays after evolving HOT 1
- GBAGFX does not support Linux line endings for palettes HOT 1
- Make triple layer metatiles available more easily
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokeemerald-expansion.