givemon is shiny locked about pokeemerald-expansion

[DizzyEggg]

So basically givemon always gives either a shiny mon or a regular one? And we would like a third random option? It could work, so that 0 - always normal, 1 - always shiny and any other value would be random. Does that sound good?

[Bassoonian]

So basically givemon always gives either a shiny mon or a regular one?

Correct

And we would like a third random option?

The issue is that the shininess became a locked value due to givemon being reimplemented from a debugging perspective, rather than the almost exclusively vanilla case where shininess is regularly left over to the RNG. I would personally go as far as vouching that the default value (i.e. 0) should cause a random roll and that other values (1 and 2, presumably) would result into either locking it as shiny or non-shiny

[mrgriffin]

I think #2806 might address givemon: https://github.com/rh-hideout/pokeemerald-expansion/pull/2806/files#diff-dcf69379dc1632054ee142ffde1654c1c89bd7d709495e2533c749691c088cd0R449

[Bassoonian]

Then it definitely needs to be reviewed, haha