Coder Social home page Coder Social logo

Comments (4)

rgc99 avatar rgc99 commented on August 15, 2024

Hi Juan,

First off I can see the adjust_time service call was issued after the sequence was started. The adjustment must be made before the schedule has commenced. It can be thought of as adjusting future runs. The entire sequence is a block or set and once started adjustments will be ignored until completed.

from irrigation_unlimited.

juacas avatar juacas commented on August 15, 2024

Hi,
thank you for your fast answer. It made sense.
Apparently it seems to not work with an sequence that has many repetitions. Maybe the effect is that the adjustment is applied over the total, accumulated duration of the sequence and the adjustment is shared proportionally over a very long time?

However, with a simple, shorter sequence the adjustment is applied to the whole sequence. The adjustment time is divided among all the zones so the total duration of the cycle is the one specified in the adjustment time. That is, an adjustment of 15 minutes are assigned as 5 minutes for each one of 3 zones (equal duration).

Thank you again for this awesome component.

from irrigation_unlimited.

rgc99 avatar rgc99 commented on August 15, 2024

Interesting point about the repetitions. To be honest, I am not exactly sure how this plays out with adjustments. Will look into it.

Yes, the adjustment time specified is the total for the sequence. The new time is compared to the original time to produce a scaling factor. This scaling factor is then applied to each zone's original duration. The total run time will be close to the specified time but some variation will occur due to rounding. Decrease the granularity if you need more accuracy.

from irrigation_unlimited.

juacas avatar juacas commented on August 15, 2024

Actually, I was trying to set the maximun time of the zone with the greater duration (the rest proportionally). Now I'll go by using percentages.
Again, great job!

from irrigation_unlimited.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.