Coder Social home page Coder Social logo

Comments (4)

 avatar commented on May 29, 2024

It's not effort-minutes. You'll see it will take much more time. Especially taking into account the fact Revel has a weak test coverage.
Apart from that, I'd like to warn you against use of filepath.Join everywhere thoughtlessly. Revel converts paths to import paths, saves paths in the template. When you start implementing this you'll see there is more benefit in using normalized (*nix style) form everywhere except when reading/writing stuff from/to the FS.

from cmd.

jeevatkm avatar jeevatkm commented on May 29, 2024

@alkchr thanks for your suggestion and inputs. Yes I agree on test coverage, I'm planning work on test coverage after v0.13 release. It may not happen overnight but gradually we can increase it. If you can spare sometime for test coverage and submitting PR it would be great. I highly appreciate your help and effort.

While working on PRs #14 and revel/revel#1028 I already did my homework on this. Revel (revel/revel & revel/cmd) has 52+ reference to path.* also I had a look on import paths vs filesystem path manipulation case by case.

If you don't mind, I would like to take help from you for the testing.

from cmd.

jeevatkm avatar jeevatkm commented on May 29, 2024

Started working on...

from cmd.

jeevatkm avatar jeevatkm commented on May 29, 2024

Done!

from cmd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.