Comments (4)
It's not effort-minutes
. You'll see it will take much more time. Especially taking into account the fact Revel has a weak test coverage.
Apart from that, I'd like to warn you against use of filepath.Join
everywhere thoughtlessly. Revel converts paths to import paths, saves paths in the template. When you start implementing this you'll see there is more benefit in using normalized (*nix style) form everywhere except when reading/writing stuff from/to the FS.
from cmd.
@alkchr thanks for your suggestion and inputs. Yes I agree on test coverage, I'm planning work on test coverage after v0.13 release. It may not happen overnight but gradually we can increase it. If you can spare sometime for test coverage and submitting PR it would be great. I highly appreciate your help and effort.
While working on PRs #14 and revel/revel#1028 I already did my homework on this. Revel (revel/revel
& revel/cmd
) has 52+ reference to path.*
also I had a look on import paths vs filesystem path manipulation case by case.
If you don't mind, I would like to take help from you for the testing.
from cmd.
Started working on...
from cmd.
Done!
from cmd.
Related Issues (20)
- Could not find import issue HOT 1
- Can't create a new app on Windows HOT 3
- Support go modules (go.mod) instead of dep HOT 4
- Create docker image or dockerfile
- revel package HOT 1
- Failed to find Revel version HOT 8
- Mode flag failing HOT 2
- Arg types in generated routes.go and run.go HOT 4
- test suite issue
- Inconsistent behavoir between revel run and revel test
- Failed to parse port as integer: %!s(int=-1) HOT 2
- support go modules, panic: runtime error: invalid memory address or nil pointer dereference HOT 1
- If the test command fails to assert, set the Exit Status to non-zero.
- build command generates unnecessary files HOT 1
- Harness Compilation error page has status 200 OK
- command not found HOT 3
- Dependency not found - github.com/myesui/uuid HOT 3
- revel run nil pointer dereference HOT 2
- Installation command doesn't work HOT 1
- Validation Key Index Line Number Mismatch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmd.