Comments (3)
If ActiveBookState
doesn't delare a lot of properties that all conforming types have to implement, and for which the protocol creates a useful abstraction, I'd start with an enum
instead.
As for the subscription:
@ObservedObject var activeBookState: Subscriber<ActiveBookState>
= Subscriber(store) { $0.select { $0.activeBookState } }
This looks fine if you're interested in the general type (or the enum itself.
For the binding, I'd introduce (derived) view model data:
.disabled(activeBookStateIsActive)
and then
or, cheekily, in a private extension to your UI component for convenience:
extension TheSwiftUIView {
fileprivate var activeBookStateIsActive: Bool { activeBookstate.value is ActiveBook }
}
With an enum, these things would flow a bit more naturally. I'm personally not a fan of boolean type checks. If that's used, it can probably also be modeled as a property of the receiving object instead, too, e.g.:
protocol ActiveBookState {
var isActive: Bool { get }
}
struct NoActiveBookState : ActiveBookState {
var isActive: Bool { false }
}
struct ActiveBook: ActiveBookState {
var isActive: Bool { true }
// other props
}
The type names and the property in combination sound super weird, though :) I'd try to come up with something else to be honest that expresses the different kinds better
from reswift.
@DivineDominion This is fantastic! Thank you so much for your comprehensive writeup. I'm going to try out your suggestions. I was leaning towards using an enum but was not sure if that was standard practice or not. I'm a bit new to Swift and iOS so excuse my ignorance. I typically live in Android land. I also agree with you that my naming is a bit weird... Diffidently a work in progress. :)
from reswift.
@alexwhb Swift enums are pretty powerful but also weird at first. Your sample code's types looked similar to the Result
or Optional
type to me, so that's why I suggested using an enum. When a type hierarchy makes more sense, by all means use that :)
Am closing the issue for now. Please reopen if things don't work.
from reswift.
Related Issues (20)
- Concurrency - protected reads HOT 2
- How to subscribe/unsubscribe store in a UIView like in UITableViewCell, CollectionViewCell etc ? HOT 1
- Managing ReSwift app state inside FileDocument HOT 1
- Remove Travis from all ReSwift repos? / How to set up GH Actions
- ReSwift 7 Roadmap HOT 20
- Docs: Update outdated and vulnerable jQuery version HOT 3
- Array as a State HOT 1
- Clarification on Single Store object for an application. HOT 1
- Change visibility of Store from 'open' to 'public final'? HOT 2
- SIGSEGV on state.didSet HOT 4
- Using Inject with ReSwift HOT 1
- Testing: Waiting for store.dispatch() to complete HOT 2
- Huge CPU gap between ReSwift Store vs just SwiftUI ObservableObject HOT 1
- Crash: sometimes will crash at this point, what can i do to find the root cause HOT 11
- Crash when dispatching actions from inside StoreSubscriber.newState() HOT 2
- How to use a state on recursive screens? HOT 4
- Filter on updates not working HOT 3
- When do you upgrade ReSwiftRouter ? Now,ReSwiftRouter just depends ReSwift 5.0.0, but lasted ReSwift is 6.1.1 HOT 2
- Privacy Manifest HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reswift.