More info in circular references diagnostics about reanalyze

[cristianoc]

And that's an old message too, coming from a time when there was not a complete fixpoint computed. In reality there's no inaccuracy left.

The one thing left is: if the sources are coming from a pre-processor, which sprinkled with things like

#1 "eol_detect.ml"

then the location info is going to be inaccurate, and might lead to cycles only for that reason.

The issue in that case is not going to be the cycle, but the incorrect info.
Perhaps I'll just add a warning somewhere that there's the assumption that those line directives are not used.

Btw Q: is there a way to ignore those directives, perhaps as a project compilation setting? That would take care of the issues.

[jberdine]

Hmm, ok, don't worry about this for now then, I'll hunt some more.

[jberdine]

Btw Q: is there a way to ignore those directives, perhaps as a project compilation setting? That would take care of the issues.

Well, ocamlformat silently removes them, so for ocaml code there is that. :-)

There must be a reasonably simple pre-processor that would remove them though.

[cristianoc]

Turned off the warning, as it's of little value. Mostly just noise and confusing.
1aa7f46