Coder Social home page Coder Social logo

Memory leak... about requestly HOT 9 CLOSED

requestly avatar requestly commented on May 8, 2024
Memory leak...

from requestly.

Comments (9)

sachinjain024 avatar sachinjain024 commented on May 8, 2024 1

@sarathnair @isiahmeadows Sorry for responding so late on this ticket. I actually forgot to update this one. We have made some cleanups in the code and removed some unused code+library.

I am expecting that should fix the issue. If by chance, you guys are still using Requestly (That would be a huge thing for me), can you please let me know if you face this?

from requestly.

dead-claudia avatar dead-claudia commented on May 8, 2024 1

@sachinjain024 I'm not seeing it on my end any more and haven't for a while, so I think this could be closed.

from requestly.

dead-claudia avatar dead-claudia commented on May 8, 2024

For such a simple tool conceptually, that's way too much memory.

from requestly.

sachinjain024 avatar sachinjain024 commented on May 8, 2024

@isiahmeadows Thanks for logging this. I'd definitely keep this in mind in my development and will often check for memory consumption by this.

How did you check the memory consumption? Did you use Chrome Task Manager? Here is a screenshot of my device.

screenshot 2017-03-09 10 18 34

Of all the extensions I use, Requestly came at the bottom with ~40 MBs of memory and I think that's fair. Although I can not provide the breakdown of memory consumption within the extension. The only things Requestly caches are:

  1. List of all rules are in memory
  2. Listeners on Storage and other chrome events

What's your expectation? What should be the memory consumption?

from requestly.

dead-claudia avatar dead-claudia commented on May 8, 2024

I did use Chrome's task manager. I didn't take a screenshot, though. It also takes several hours to get truly problematic (after ~10 hours, it usually hits about 300-400MB), so it's not something that quickly appears.

I would normally expect Requestly to stay near the bottom while not filtering anything, and slow memory leaks aren't easily caught.

Any idea where I could find the relevant source code? I'm actually willing to help rectify this when I can find time.

from requestly.

sarathnair avatar sarathnair commented on May 8, 2024

I have also experienced memory leak in program. I have set up some rules in requestly. These rules basically replace the URL. Every time I refresh my page I can see in Chrome's task manager that memory goes up and never comes down. For my application the requestly extension consumes additional 2MB memory in each page reload. This is a critical issue and should be looked into immediately.

from requestly.

sachinjain024 avatar sachinjain024 commented on May 8, 2024

@sarathnair Can you please give me a screenshot of your chrome task manager. I just wanted to view the memory consumption by other tabs/processes as well before considering this as issue. Normally, chrome keeps on hogging memory if you do not refresh the page for a long time. I think the same holds true for extensions as well. Can you check the memory usage by other extensions as well ?

from requestly.

sarathnair avatar sarathnair commented on May 8, 2024

@sachinjain024
image

Here is the screen shot you asked. After a couple of refresh I see below:

image

I see similar behavior in Adblocker extension. But after a while Adblocker seems to release memory and come back its previous state.

from requestly.

sachinjain024 avatar sachinjain024 commented on May 8, 2024

Thanks @isiahmeadows for confirming. Feel free to give us suggestions/feedbacks.You can also reachout to us at requestly dot extension at gmail dot com.

from requestly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.