Comments (4)
i'm supportive of this addition. i would like to see us avoid abbreviations, so i'd prefer variables
over vars
, but this otherwise seems reasonable. PRs welcome. I will be stepping away for a couple of weeks, but will catch up afterward.
from app.
Any movement on this?
from app.
@rlmartin I took a stab at getting the support in place, but the ability to add environment varaibles required the repository id not the name so I had to add an extra call to get this.
@travi It does not look like the repository id is used anywhere else and the context for what is handed into the app is unclear if this is already on the this.repo object as something like this.repo.id
. If that is the case it simplifies the code a lot and I will not have to make the additional call to get the id.
If the call is needed then I need a bit of help fixing the mock as my jest skills are a bit rusty and I can't seem to figure out why the mock to the get repository isn't working. 🤷
from app.
sorry for the delay responding on this one. i was working on refactoring the integration tests and upgrading to the latest probot version, so i didnt want my feedback to change after working through that effort.
the ability to add environment varaibles required the repository id not the name so I had to add an extra call to get this
can you point to documentation related to this? this doesnt align with what i'm finding. for example, this doc highlights that the repository name is needed, not the id: https://docs.github.com/en/rest/actions/variables?apiVersion=2022-11-28#create-an-environment-variable
the context for what is handed into the app is unclear if this is already on the this.repo object as something like
this.repo.id
.
the repo data populated in this.repo
comes from the webhook payload that is received in our listeners. https://github.com/octokit/webhooks/ is a good reference for the expected content of these payloads. for example, here is an example of how repository
is represented in a push
webhook.
I need a bit of help fixing the mock as my jest skills are a bit rusty and I can't seem to figure out why the mock to the get repository isn't working.
i agree that the previous testing approach was a bit awkward, so i used the upgrade to the latest probot version as an excuse to rework the approach for integration testing. use of cucumber enabled making the scenarios a lot easier to describe and understand when approaching the project without the whole thing already in your head. hopefully this helps make things more clear, but let me know if additional guidance would be helpful
from app.
Related Issues (20)
- feature: add repositories rules
- Feature: Enable/Disable Advanced Security
- Support for the auto-merge option HOT 3
- move away from prettier-standard
- Feature: Accessible Error Messages HOT 1
- App
- Token
- 58cfedc52f2c398817615caed4d6a79719c0271e
- Add support for adding Protected Tags HOT 1
- Allow .yaml
- Verify Publisher HOT 1
- Exchange's
- __Originally posted by @Ranchosm335 in https://github.com/repository-settings/app/issues/810__
- Recent GitHub change breaks required workflows / branch protection rules HOT 2
- https://t.me/jacker_jak
- We are creating custom xcframework by using GCDWebServer in the pod file. when we use the created xcframework in our application, build failed with the error - 'GCDWebServer' is not a member type of class 'GCDWebServer.GCDWebServer
- good
- branches config does not work at all HOT 5
- Repository archiving support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app.