Comments (7)
Lemme work on making store-identity more robust.
from datahike.
@whilo @TimoKramer thoughts?
from datahike.
I think disabling might not be the best idea. The problem is once you connect to a store with a potentially incompatible configuration you might corrupt the database. I agree that the jdbcUrl
should be allowed to be different for the hostname and port. Maybe we could provide a multimethod that is implemented by every store and only returns the part of the config that should be matched.
from datahike.
store-identity
is supposed to do that, I need to check again how it works for JDBC. Alternatively we could still use the random names and add them to every store and just rely on that.
from datahike.
@whilo I've almost completed the store-identity
work on datahike-jdbc
. The missing part in on the datahike side. The comparison doesn't use the store-identity
: https://github.com/replikativ/datahike/blob/166cdbbb7031fa03e619091fb7a99c20cd550ec3/src/datahike/connector.cljc#L126C18-L126C18
from datahike.
Right, I think it should break out the store config there and run store-identity on it and then equality check that.
from datahike.
Resolved by #655
from datahike.
Related Issues (20)
- Extend integration-test namespace
- [Bug]: prep-lib is broken HOT 5
- [Bug]: CI token not valid, no release possible
- [Bug]: can't import datahike.api at repl: Unable to resolve symbol: abs HOT 3
- CI: compile and upload native-image binaries to GitHub Releases HOT 2
- Reflection warnings need to be fixed for native Datahike HOT 3
- [Bug]: datahike.migrate has a problem with schema/double (which cbor converts to float) HOT 2
- [Bug]: unneeded dependencies pulled HOT 7
- Integrate HTTP server HOT 4
- Improve connection handling HOT 1
- [Bug]: NullPointerException trying to transact from CLI HOT 8
- [Bug]: FileNotFoundException over resources/datahike-logo.txt HOT 2
- [Bug]: Inconsistent treatment of invalid constant values HOT 2
- [Bug]: Unable to use Datahike as a git library HOT 2
- [Bug]: `pull-many` query with 3 attr-ids on a range of 500 entities takes ~2,900 ms
- chore: simplify state management
- [Bug]: :config-does-not-match-stored-db for file storage when using VPN HOT 5
- [Bug]: Problem with bump org.babashka/tools-deps-native from 0.1.1 to 0.1.2 and `datahike-logo.txt` not being packaged into the jar
- [Bug]: Metadata is incorrect for various functions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datahike.