Coder Social home page Coder Social logo

Comments (7)

alekcz avatar alekcz commented on July 26, 2024 1

Lemme work on making store-identity more robust.

from datahike.

alekcz avatar alekcz commented on July 26, 2024

@whilo @TimoKramer thoughts?

from datahike.

whilo avatar whilo commented on July 26, 2024

I think disabling might not be the best idea. The problem is once you connect to a store with a potentially incompatible configuration you might corrupt the database. I agree that the jdbcUrl should be allowed to be different for the hostname and port. Maybe we could provide a multimethod that is implemented by every store and only returns the part of the config that should be matched.

from datahike.

whilo avatar whilo commented on July 26, 2024

store-identity is supposed to do that, I need to check again how it works for JDBC. Alternatively we could still use the random names and add them to every store and just rely on that.

from datahike.

alekcz avatar alekcz commented on July 26, 2024

@whilo I've almost completed the store-identity work on datahike-jdbc. The missing part in on the datahike side. The comparison doesn't use the store-identity: https://github.com/replikativ/datahike/blob/166cdbbb7031fa03e619091fb7a99c20cd550ec3/src/datahike/connector.cljc#L126C18-L126C18

from datahike.

whilo avatar whilo commented on July 26, 2024

Right, I think it should break out the store config there and run store-identity on it and then equality check that.

from datahike.

alekcz avatar alekcz commented on July 26, 2024

Resolved by #655

from datahike.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.