Comments (3)
koosh
commented on July 30, 2024
1
Upon further looking there's many different public methods both AuthResponse and PaymentResponse provide, that are not part of the interface. And it looks like there are very clear use cases (auth and payment) that require different interfaces. Changes for the sake of change are not something this package needs, its working just fine. So I'll leave it as it is.
from banklink.
renekorss
commented on July 30, 2024
Thanks for reporting and noticing. I would be glad if you would make PR. Please use first solution, since it feels cleaner and more logical to me.
I will mark you as assignee, let me know if it's not okay with you.
from banklink.
renekorss
commented on July 30, 2024
Thanks for looking into it!
from banklink.
Related Issues (16)
- VK_STAMP could be string as well HOT 6
- Test request url COOPPANK HOT 3
- Feature request: ability to set different return and cancel urls HOT 5
- orderId type from int to string in protocol requests HOT 1
- Problem of PHP versions HOT 4
- Problem of PHP 7.0 version support HOT 1
- Swedbank LT doesn't include VK_RETURN into mac HOT 2
- Rename Liizi to Liisi through the project
- New Luminor banklink HOT 2
- New provider: Everypay
- Rename banks HOT 4
- Add Pocopay support
- Banklink implementation sets VK_REF and VK_MSG even if LtSwedbank specification allows only one of the fields to be used HOT 15
- Drop PHP 5.6 & 7.0 support
- Add support for separate request URLs for auth and payment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from banklink.