Coder Social home page Coder Social logo

Comments (4)

jerone avatar jerone commented on July 29, 2024

Apparently this was previous the way it worked before removing it after having problems with IE8's fireEvent: 898b546
Array.prototype.indexOf() is only supported since IE 9.

from polyfills.

sandersky avatar sandersky commented on July 29, 2024

Well I still think the current implementation is wrong. If I have an element with the class items and check that the element contains the class item it will return true because item is a substring of items while the class item doesn't actually exist on the element.

from polyfills.

jerone avatar jerone commented on July 29, 2024

@sandersky commented on 26 aug. 2014 21:09 CEST:

Well I still think the current implementation is wrong. If I have an element with the class items and check that the element contains the class item it will return true because item is a substring of items while the class item doesn't actually exist on the element.

Seems a valid bug, you're right.

Wish above commit had a bug report attached to it; searching the Internet didn't find any similar issues with Array.prototype.indexOf() and IE's fireEvent.

Edit:
Found the corresponding PR, but no real explanation.

from polyfills.

sandersky avatar sandersky commented on July 29, 2024

For me I only care about IE9 and above since IE8 is no longer supported by Microsoft (since April when they stopped XP support). With this being said I opted for the indexOf solution in my project. If I find time I'll submit an IE8 friendly fix to the issue I addressed.

from polyfills.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.