Coder Social home page Coder Social logo

Comments (3)

ryanflorence avatar ryanflorence commented on November 10, 2024

How does it feel if your handler is not the fluxxor app, but rather a handler that renders the fluxxor app? Gives you a chance to know you have the props.

Sent from my iPhone

On Jun 30, 2014, at 8:59 AM, Luigy Leon [email protected] wrote:

On the first pass, the handler's props are undefined. As soon as the route is mounted it runs all transition hooks needed to sync with the current URL. When this is done, it knows its props which include any static props that were passed to the Route. -- @mjackson

Apps with required props (like with fluxxor) would get warnings of missing props on first render

var routes = (

...

);
"Warning: Required prop flux was not specified in FluxxorApp."

Do you need to be able to pass static props through to the handler on the first render pass? If so, we could easily make that change.

Yes

maybe just transferPropsTo if no this.state.matches

render: function() {
var props = computeHandlerProps(this.state.matches || [], this.state.activeQuery);
var handler = this.props.handler(props);
if (!this.state.matches) {
return this.transferPropsTo(handler);
}
return handler;
}

Reply to this email directly or view it on GitHub.

from react-router.

luigy avatar luigy commented on November 10, 2024

It feels better and even more obvious once server rendering lands

from react-router.

joecritch avatar joecritch commented on November 10, 2024

A demo of how to do what @rpflorence has mentioned above (using an intermediary component to check for the existence of this.props.flux). https://gist.github.com/joecritch/0bf7855bfc58df8c7f06. Not sure if there's a better way.

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.