Comments (3)
How does it feel if your handler is not the fluxxor app, but rather a handler that renders the fluxxor app? Gives you a chance to know you have the props.
Sent from my iPhone
On Jun 30, 2014, at 8:59 AM, Luigy Leon [email protected] wrote:
On the first pass, the handler's props are undefined. As soon as the route is mounted it runs all transition hooks needed to sync with the current URL. When this is done, it knows its props which include any static props that were passed to the Route. -- @mjackson
Apps with required props (like with fluxxor) would get warnings of missing props on first render
var routes = (
...
);
"Warning: Required prop flux was not specified in FluxxorApp."Do you need to be able to pass static props through to the handler on the first render pass? If so, we could easily make that change.
Yes
maybe just transferPropsTo if no this.state.matches
render: function() {
var props = computeHandlerProps(this.state.matches || [], this.state.activeQuery);
var handler = this.props.handler(props);
if (!this.state.matches) {
return this.transferPropsTo(handler);
}
return handler;
}
—
Reply to this email directly or view it on GitHub.
from react-router.
It feels better and even more obvious once server rendering lands
from react-router.
A demo of how to do what @rpflorence has mentioned above (using an intermediary component to check for the existence of this.props.flux
). https://gist.github.com/joecritch/0bf7855bfc58df8c7f06. Not sure if there's a better way.
from react-router.
Related Issues (20)
- [Bug]: (a11y)-Multiple accessibility issues with React-Router HOT 1
- [Bug]: The global state manager does not work in conjunction with react-router-dom HOT 1
- [Bug]: encoded # in path parameter causes route to be evaluated differently
- [Bug]: generatePath/matchPath don't handle encoding/decoding `/` the same HOT 1
- [Bug]: Support non-standard HTTP methods in Resource Routes HOT 3
- [Bug]: react-router seems to depend on vulnerable versions of path-to-regexp HOT 8
- [Bug]: react-router-dom v5 uses vulnerable version of path-to-regexp HOT 6
- [Bug]: Mount happens twice on forward navigation HOT 2
- [Bug]: type errors with `exactOptionalPropertyTypes` HOT 5
- [Bug]: React-router does not work with react 18, besides using router v6.12.0 HOT 1
- [Bug]: ScrollRestoration doesn't restore horizontal page scroll HOT 1
- [Bug]: Component does not load for JSX-returning arrow functions HOT 1
- [Bug]: Can we check shouldRevalidation before we cancel a loader? HOT 4
- [Bug]: unstable_patchRoutesOnNavigation doesn't handle multiple click correctly while loading HOT 2
- [Bug]: useLoaderData returns undefined when animating page transitions HOT 4
- [Docs]: Grammatical error. It should be "further along" not "farther along" HOT 1
- [Bug]: createRouter never defined in the CDNJS package HOT 3
- [Bug]: `JsonObject` type reports issues in Remix's `useSubmit` that are technically okay, making workarounds extense HOT 3
- Get "Expected fetch controller: :r1:" when calling fetcher.load and revalidator.revalidate HOT 4
- [Bug]: useNavigate function does not work inside event listener (application is called within iframe) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.