Comments (7)
The current boundary between sync and async lands is at Route#dispatch
(in the route-component branch). Routes use this method to update their state when the URL changes. It's nice to keep this boundary at a low level so it doesn't permeate the rest of the API. For example, the URLStore
would need to know about promises in order to make Router.transitionTo
return a promise.
Anyway, the best we could do would be to return a promise that resolves immediately after the call to route.setState
, which doesn't necessarily mean that changes have been made to the DOM.
Would it be too much hassle to ask people to use componentDidMount
and/or componentDidUpdate
in their tests? If people absolutely need to know when a transition
is completed, maybe we could provide a didTransitionTo
transition hook?
from react-router.
When integration testing you'll need to know exactly when you can start asserting the screen has the data you expect.
from react-router.
Right. Seems like that's exactly what componentDidUpdate
is for.
from react-router.
depending on the app's architecture, couldn't componentDidUpdate fire multiple times before a single 'transition' is over?
from react-router.
For integration tests we will need some sort of hooks to know that transitions and when data from #57 have landed before making assertions.
We should have some test helpers for this.
from react-router.
The hook you're looking for is Route#dispatch
. That method returns a promise that resolves when the transition is complete and the ActiveStore
has been updated.
from react-router.
closing for a different converstaion
from react-router.
Related Issues (20)
- [Bug]: Relative option is not work in useNavigate HOT 3
- [Bug]: (a11y)-Multiple accessibility issues with React-Router HOT 1
- [Bug]: The global state manager does not work in conjunction with react-router-dom HOT 1
- [Bug]: encoded # in path parameter causes route to be evaluated differently
- [Bug]: generatePath/matchPath don't handle encoding/decoding `/` the same HOT 1
- [Bug]: Support non-standard HTTP methods in Resource Routes HOT 3
- [Bug]: react-router seems to depend on vulnerable versions of path-to-regexp HOT 8
- [Bug]: react-router-dom v5 uses vulnerable version of path-to-regexp HOT 6
- [Bug]: Mount happens twice on forward navigation HOT 2
- [Bug]: type errors with `exactOptionalPropertyTypes` HOT 5
- [Bug]: React-router does not work with react 18, besides using router v6.12.0 HOT 1
- [Bug]: ScrollRestoration doesn't restore horizontal page scroll HOT 1
- [Bug]: Component does not load for JSX-returning arrow functions HOT 1
- [Bug]: Can we check shouldRevalidation before we cancel a loader? HOT 4
- [Bug]: unstable_patchRoutesOnNavigation doesn't handle multiple click correctly while loading HOT 2
- [Bug]: useLoaderData returns undefined when animating page transitions HOT 4
- [Docs]: Grammatical error. It should be "further along" not "farther along" HOT 1
- [Bug]: createRouter never defined in the CDNJS package HOT 3
- [Bug]: `JsonObject` type reports issues in Remix's `useSubmit` that are technically okay, making workarounds extense HOT 3
- Get "Expected fetch controller: :r1:" when calling fetcher.load and revalidator.revalidate HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.