Coder Social home page Coder Social logo

Comments (6)

KidkArolis avatar KidkArolis commented on November 11, 2024

well.. the rule is quite simple - promises should always be returned

here many promises are being created in a loop, but only the last one is getting returned
https://github.com/rpflorence/react-router/blob/7fc55834e9f607f553c96774c99c8cc7785b1c26/lib/router.js#L522

replace with smth like

return when.map(reversedArray(matches), function () {
  ... make your promise ...
  return promise;
});

from react-router.

andreypopp avatar andreypopp commented on November 11, 2024

I'd also suggest using bluebird promise library which logs uncaught errors in browser console.

from react-router.

KidkArolis avatar KidkArolis commented on November 11, 2024

Or when.

from react-router.

ryanflorence avatar ryanflorence commented on November 11, 2024

"just do promises right" :P

Anyway, not actually interested in a promise conversation (I was just bugging Michael about them before this commit, talking about how people always mess them up and then app code errors get swallowed, so it was fun for me to come back and say "see ... pain in the neck").

I have two requirements though:

  1. We don't swallow user's code in our promise usage
  2. We support a simple callback in transition hooks so people don't have to use promises in application code because half of us have had nothing but bad experiences with them.

I do not want to constantly be having promise conversations with people using this library.

from react-router.

mjackson avatar mjackson commented on November 11, 2024

I'll take a look at this today. @rpflorence I agree that the last thing I want is to have endless conversations with people trying to track down swallowed errors, so we'll just fix it and not swallow them. If we can't, we'll remove support for them.

from react-router.

mjackson avatar mjackson commented on November 11, 2024

BTW, I'd be happy to discuss support for callbacks in transition hooks in a separate issue. Promises give us guarantees that callbacks don't, and they present a really clean interface for dealing with asynchronous code.

@andreypopp I used es6-promise because it's just a shim instead of a full-blown library with lots of extra bells and whistles. Using es6-promise today means we can easily remove it at some point in the future when more runtimes support a native Promise.

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.