Coder Social home page Coder Social logo

Comments (2)

mjackson avatar mjackson commented on April 19, 2024

The more I think about this, the more I'm convinced that we don't really need a NotFound handler. Instead, it really comes down to how Router#transitionTo is being called.

If a user is calling transitionTo directly on a Router instance, and the router can't match on the given path, we should throw. Plain as that.

If we're calling transitionTo automatically from a URL change and the router can't match on the current URL, we could print a warning to the console and just leave the state of the router as it is. The next time the URL changes to something that router does recognize, it will update accordingly.

from react-router.

mjackson avatar mjackson commented on April 19, 2024

I removed the Router#transitionTo API entirely, so this is no longer an issue.

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.