Comments (2)
The more I think about this, the more I'm convinced that we don't really need a NotFound
handler. Instead, it really comes down to how Router#transitionTo
is being called.
If a user is calling transitionTo
directly on a Router
instance, and the router can't match on the given path, we should throw
. Plain as that.
If we're calling transitionTo
automatically from a URL change and the router can't match on the current URL, we could print a warning to the console and just leave the state of the router as it is. The next time the URL changes to something that router does recognize, it will update accordingly.
from react-router.
I removed the Router#transitionTo
API entirely, so this is no longer an issue.
from react-router.
Related Issues (20)
- [Bug]: "react-router-dom-v5-compat" <CompatRouter> doesn't unsubscribe from history potentially causing tests to memory leak HOT 2
- [Bug]: child loader redirect overrides parent loader error HOT 7
- [Bug]: v7_partialHydration with unstable_patchRoutesOnMiss: hydrateFallbackElement not shown on patched routes HOT 5
- [Bug]: Relative path does not work as expected in outlets HOT 1
- [Bug]: useNavigate causes component to rerender HOT 3
- [Bug]: react-aria-components Link - wrong href for external links integrating with React Router HOT 1
- [Bug]: Spurious rerender at the start of a load HOT 4
- [Bug]: HashRouter need to wrapped twice HOT 1
- [Bug]: returning `replace` from loader replaces an extra entry HOT 8
- [Bug]: When the page returns, there is a noticeable delay/latency. HOT 1
- [Bug]: Navlink className function props not work as expected it HOT 2
- [Docs]: Switched parameters in matchPath HOT 1
- [Bug]: Unable to match a url that ends in an equal sign HOT 1
- [Bug]: optional segments with dynamic segments HOT 1
- [Bug]: State is not preserved in a component tree when switching to render via custom `<Routes location={location}>` prop
- [Bug]: undefined is not an object (evaluating ' request.signal.aborted ') HOT 1
- [Bug]: "TypeError: URL constructor: // is not a valid URL" while using data router HOT 9
- [Bug]: Relative option is not work in useNavigate HOT 3
- [Bug]: (a11y)-Multiple accessibility issues with React-Router HOT 1
- [Bug]: The global state manager does not work in conjunction with react-router-dom HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.