Comments (11)
Closed by #102
from indie-stack.
Will probably be fixed by #102
from indie-stack.
I don't think this fully fixed it 😢 I just created a new project by running npx create-remix --template remix-run/indie-stack
and following the readme. npm ci
works locally but fails on CI.
from indie-stack.
This got me past that npm ci
error.
index d01b1b0..a45574c 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -100,7 +100,7 @@ jobs:
- name: 📥 Download deps
uses: bahmutov/npm-install@v1
with:
- useLockFile: false
+ useLockFile: true
- name: 🛠 Setup Database
run: npx prisma migrate reset --force
from indie-stack.
ah yep, the first run won't have a lock file until the deps are installed due to #79, so npm ci will fail, personally i think it's fine to have them by default and if someone wants to use a diff package manager, they'll know what to do - especially because we still use npm in the Dockerfile
from indie-stack.
@mcansh Could we add some output to the CI about this to avoid confusing users?
from indie-stack.
something like? I'm not sure this is better than just having one by default as we still use npm
in the Dockerfile
- name: Check for lockfile
run: |
FILE=package-lock.json
if [ ! -f "$FILE" ]; then
echo "$FILE does not exist. Please run `npm install` before continuing"
exit 1
fi
however! just thought about this, we could potentially check for the package manager in github and pass that to Docker for it to know which files to copy and which PM to use 🤔
from indie-stack.
from indie-stack.
I think by explicitly disabling the lock file, it would check out different versions of packages and then that causes "npm ci" to complain about them being out of sync.
something is definitely up, but i don't think that's it as opting out of the lock file uses npm install
and not npm ci
https://github.com/bahmutov/npm-install/blob/master/index.js#L112
from indie-stack.
interesting, i just created a new app and the cypress job passed https://github.com/mcansh/indie-stack-test/runs/6971217149?check_suite_focus=true
from indie-stack.
Closing this issue as no response was provided.
Feel free to re-open it if it's still a problem.
from indie-stack.
Related Issues (20)
- Logout directly by hiting http://localhost:3000/logout should remove the cookie stored in the browser HOT 3
- Collaborator init script is missing HOT 5
- Warning: Expected server HTML to contain a matching <meta> in <head> HOT 5
- Fly Instance runs out of memory on deployment HOT 11
- Failed app run HOT 3
- Missing Environment Variables when Prisma is removed HOT 3
- Env variables undefined in build but fine in dev HOT 1
- pnpm is not preinstalled and causes an error in Cypress HOT 3
- No region defined in the fly deploy command, causes deployment to crash HOT 10
- Remix and Cypress hydration problem HOT 7
- hydration failed,and css file will request twice HOT 1
- npm run dev errors out in windows machines with "Cannot find module '--require/package.json'"
- Error during deployment in Fly.io, Dockerfile needs to give permissons to `start.sh` script HOT 3
- Timeout when Running e2e tests on a fresh installation
- Typecheck fails because it can't find definitions for cypress or @testing-library/cypress HOT 6
- throw new Error(`Failed to kill process ${pid}: ${error}`) after code change HOT 3
- Tailwind SourceMap/EsBuild Issue HOT 4
- Error upon deployment: you must be authenticated
- Cypress custom commands doesn't load HOT 2
- Use `fly launch`/`dockerfile-node` instead of `.dockerignore`, `Dockerfile`, `fly.toml` & `start.sh` HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from indie-stack.