Tests not passing about grunge-stack

[salper]

I've been using remix for a while now, and the Buffer is not defined issue has been there since the unstable_* multipart feature. Curiously, the unstable_parseMultipartFormData, which relies on busboy (calling Buffer) is bundled in the client dist while not being used at all in the routes, so something must be wrong in the esbuild config.

[salper]

What's weird is that unstable_createMemoryUploadHandler is bundled when unstable_createFileUploadHandlerfrom is not, so that could be a clue.

[joaogomesdev]

Yeah, it's weird because I literally just cloned and installed the dependencies. And then I run the tests and they don't work

[salper]

Just dug into it. What I've found is that a simple rm -rf public/build && npm run build:remix seems to clear the issue, as the client bundle seems clean after that, so I wonder if it's not the remix-init of the stack that's doing something differently. Trying to confirm that for now.

[salper]

As said earlier, the problem has been there since the introduction of the multipart feature (don't know why I've said it could be the remix-init of the stack 🤭 ). I've tried on a baremetal install (architect+typescript), and the issue occurs between the remix watch and the remix build:

• remix build -> client bundle is clean
• remix watch -> client bundle has occurrences of unstable_createMemoryUploadHandler

[salper]

Ah! Ah! It's actually normal to have occurrences of unstable_createMemoryUploadHandler in the baremetal build folder, as it's due to the source map generation (didn't see the file extension 😱 ). So the client warning could actually be due to the stack setup, as I do have an occurence in a generated js chunk using remix watch and not remix build using the grunge stack.

[salper]

I think I've got something now. Commenting the routes entry in the remix.config.js provides a clean browser build. It makes sense as the cypress/support/test-routes/create-user.ts is included via the routes attribute only when process.env.NODE_ENV is not production. So my first guess is that routes included via the routes entry are not pruned (or tree shaken) properly, and remix is fully loaded inside (routes entry commented, the chunk is only 176K while not commented, the chunk weighs 1.1M).

[joaogomesdev]

Thanks you very much @salper for the reply!