Add `add` and `multiply` functions. about remeda

[LandonSchropp]

If you like this idea, I'm happy to open a PR. 🙂

[eranhirsch]

@TkDodo, I know these are added as examples in our mapping.Md file, but I personally feel it's OK to have them implemented as functions (similar to how 'prop' is helpful when it's similarly simple as an arrow function: ({ [prop]: value }) => value

[LandonSchropp]

For context, this fell out of some of my Advent of Code answers from this year. I found myself repeating this a lot:

return result.reduce((sum, number) => sum + number, 0);

I liked the idea of add as a utility function because I thought it made the code a bit more readable.

return result.reduce(R.add);

sumBy was an option that I used as well with R.identity:

return R.sumBy(result, R.identity);

However, it seems R.sum would be a bit tidier. (sumBy could be thought of as a composition of map and sum in this context.)

return R.sum(result);

I'm happy to close this if you'd like—just thought I'd suggest it. What do you think?

[eranhirsch]

I checked our docs, and lodash's and ramda's docs, and I am supportive of adding add, subtract, divide, and multiply. I'm especially interested in having dataLast implementations of these readily available for things like R.map(anArrayOfNumbers, R.add(SOME_CONST));

Can you send out a PR for these and I'll review it? You can bunch all of them into a single PR

[LandonSchropp]

@eranhirsch Sounds great! I'll try to get those over to you in the next few days.

[LandonSchropp]

I personally feel it's OK to have them implemented as functions

Apologies, I read that wrong the first time. For some reason, I thought you wrote that you didn't feel that it was OK to have them implemented as functions. 😬

[LandonSchropp]

@eranhirsch Hey, did you see this draft PR I opened? No worries if you're busy hand haven't had a chance to look—I just wanted to make sure you didn't miss it. 🙂

[eranhirsch]

Your comments sounded like you were planning to continue working on it, and I usually don't go over draft PRs. Is there a reason you are keeping the PR in draft?

[LandonSchropp]

Oh, I just wanted to make sure you were good with the approach before I did the rest of them.

[TkDodo]

🎉 This issue has been resolved in version 1.34.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀