Comments (5)
Doing queries now on https://api.github.com/repos/go-vikunja/frontend/releases, https://api.github.com/repos/go-vikunja/frontend/releases and https://api.github.com/repos/allinurl/goaccess/releases gives me the 992aaf92b487506974e4305db4a64326866f3ed48b2ba424cef8fbe4e28f72b0
ETag. Was it giving you 1202860668f8cc09802a90038fa4ff8cdc642644697a3ef85aace4bd6ed91973
when you tried last week?
I'm thinking that the ETag for empty releases isn't constant, so just do the first query with no ETag, and if that query on /releases
gives an empty list, then switch that Service to /tags
. Would double the API calls for repos using tags instead of releases, but only on the very first queries for each Service on startup
from argus.
Trying again with Firefox I get the same ETag I had last week (1202...
), but with curl
I get the same one you do 992a...
.
Using Firefox's dev tools "copy as curl" I get a third ETag: 40d7791495f98777a75dd6d73d7794658c7df79d296af9c37bf97c9c3aa11ecc
.
Hardcoding one of the "empty" ETags doesn't seem to have a downside so, if simple, why not? But as you said the cost is very low, so it's definitely not a big deal without either.
I just mentioned the ETag since I saw other requests use them :)
from argus.
Ah, good that it's not changed in a week.
I'll add this as a default, and on startup, do a query with that default and update the default if that's changed. I'm also adding a check for a 200 response being an empty list (incase that etag changes whilst the app is running), and having that update the default and trigger the fallback query
from argus.
Amazing, thanks!
I'll update and test later today :)
(Didn't get notified by the PRs, would've tested then otherwise!)
from argus.
Works great, thanks!
from argus.
Related Issues (20)
- bug: setting a default notifier to an empty map has no effect HOT 6
- feat: Display index thru GUI HOT 2
- feat: Update service deployed version when manually refreshing via the GUI HOT 2
- feat: Support for XPATH HOT 2
- get latest release from codeberg.org HOT 1
- feat: Ability to replace characters in either the latest_version or deployed_version HOT 6
- bug: Duplicate notifications sent HOT 5
- feat: Support for hardcoded current version HOT 2
- bug: SMTP E-Mail "fromname: XXX" not working HOT 1
- feat(web): custom favicon support HOT 1
- error --> create "" failed (fetches failed) latest_version - failed converting HOT 9
- feat: Ability to specify environment variables in config HOT 2
- bug: not rendering URL to the end HOT 2
- feat: Add a test connection for notifiers HOT 3
- feat: Add link icons in Edit Service UI HOT 6
- bug: Dockerfile stopped building 7 days ago HOT 8
- feat: Display the latest_version_timestamp for each project HOT 7
- feat: Add curl to container image HOT 1
- feat: Support for deployed version POST requests HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argus.