Window hack not extension safe about gestalt

[heilerich]

Oh I see, the appearance proxy is the problem. Thanks for the clarification! I should have thought of that myself. When reading your code comment my brain didn't parse 'appearance' to UIAppearance 😅

I think I have a working version, disabling the code in extensions if sharedApplication is not accessible. I guess this will delay delay changing the theme in the extension a little bit, but since extensions are reloaded by the OS quite frequently anyways I think this shouldn't be a problem. I will test for a few more days and drop you a PR as soon as I get round to it.

[regexident]

This is why:

"Note: iOS applies appearance changes when a view enters a window, it doesn’t change the appearance of a view that’s already in a window. To change the appearance of a view that’s currently in a window, remove the view from the view hierarchy and then put it back."

(From the documentation of UIAppearance.)

---

If you can figure out a way to make things work with app extensions I'd welcome a PR! 🤩

Maybe this might help:

I could just mention that sharedApplication actually exists in extensions, just artificially blocked due to how Apple have set up their extensions lifecycle. UIApplication.value(forKey: "sharedApplication") as! UIApplication will give you what you want. ;-)

(From comment on StackOverflow)

Or by detecting the app extension and disabling the code:

• How to detect if code is running in Main App or App Extension Target?

[regexident]

Great, looking forward to it!