Comments (7)
from utls.
Good catch. I agree that this is a bug. Would you love to submit a pull request addressing this issue?
We did not implement enough testcases to cover all the extensions, and I basically reversed the Read()
function for the Write()
. So testcases would benefit this project as well.
from utls.
Yea that's not a problem, unsure why ReadUint16LengthPrefixed reads the last element tho,,, as there should be one more read left... 07, 2, 04, 00, 00
I'll look into that (unless it treating it as \0)
from utls.
why ReadUint16LengthPrefixed reads the last element
Can you be more specific on that? Like, which bytes are you referring to as the last element?
from utls.
why ReadUint16LengthPrefixed reads the last element
Can you be more specific on that? Like, which bytes are you referring to as the last element?
with the last ignored.ReadUint16LengthPrefixed(&ignored)
there should still be 0, 0
left in that array to read, but its empty, cryptobyte appears to do something with it... i'll run some tests
[2 0 4 0 0 0 0] <-- 8
[0 4 0 0 0 0] <-- 16
[0 0 0 0] <-- 16
[] <--- missing
from utls.
When you call ignored.ReadUint16LengthPrefixed(&ignored)
when ignored == [0 0 0 0]
you are reading (consuming) next two bytes from ignored
as length
(which is 0), then put ignored[0:length] == []
into &ignored
. Basically that's where you lose the following bytes by overwriting ignored == [0 0]
with []
.
from utls.
ah right , my bad
from utls.
Related Issues (20)
- Cannot install in Docker base image alpine (package crypto/ecdh is not in GOROOT) HOT 5
- panic: tls: setSessionTicketExt failed: invalid state HOT 3
- Support for padding extension HOT 6
- feat: GREASE ECH Extension HOT 4
- bump Auto parrot for Firefox and Chrome
- bug: configuration for GREASE ECH parrot for Chrome 120 doesn't match BoringSSL HOT 7
- HelloFirefox* gets an ECDSA verification failure HOT 4
- FingerprintClientHello support for GREASE ECH extension
- Weird observation regarding ClientId and Spec HOT 9
- B uTLS does not support 0xFB1A as max version,add ja3 tls error,roundTripper error HOT 7
- crypto/ecdh is not in GOROOT (Go 1.18) HOT 1
- Secured Renegotiation is not supported HOT 10
- What is the hash function of the fingerprint in utls? HOT 6
- HTTP2 (akamai) fingerprint always same? HOT 1
- Example ImportTLSClientHelloFromJSON HOT 6
- Towards better versioning policy HOT 4
- bug: `(*Conn).Handshake()` is called upon `(*UConn).Read()` HOT 3
- *.tlsfingerprint.io down? HOT 6
- Any plans implements in Python HOT 1
- UnmarshalClientHello returns nil
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from utls.