teaser helper does not preserve html about refinerycms-blog

[joemsak]

Interesting, I'm not sure where that preserve option comes from, then,
because I've seen it around Refinery before... thanks for highlighting this

I am in the process of integrating a syntax highlighter and noticed that

line breaks and whitespace was not preserved on the index page of the blog.
I was mainly concerned for the content within "pre" and "code" tags. The
show page seemed to render fine.

I traced it back to the teaser helper:

def blog_post_teaser(post)
if post.respond_to?(:custom_teaser) && post.custom_teaser.present?
post.custom_teaser.html_safe
else
truncate(post.body, {
:length => RefinerySetting.find_or_set(:blog_post_teaser_length,
250),
:preserve_html_tags => true
}).html_safe
end
end

It seems that the truncate method is not preserving html properly. I had a
look at the rails api and I couldn't find a method to support the
:preserve_html_tags being passed. In addition, the truncate method states
in the documentation
that it does not preserve valid html.

Does the blog use another custom truncate method to preserve tags? Is this
a valid option? Perhaps something like this would be better?

Thanks!

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms-blog/issues/98

[ugisozols]

Refinery uses this plugin https://github.com/hgimenez/truncate_html and here's Refinery helper https://github.com/resolve/refinerycms/blob/master/core/lib/refinery/helpers/html_truncation_helper.rb which uses that plugin.

[astjohn]

I believe that might be the same one I found earlier. Any idea why
whitespace and line breaks are removed?

On Thu, Jul 7, 2011 at 2:22 PM, ugisozols <
[email protected]>wrote:

Refinery uses this plugin https://github.com/hgimenez/truncate_html and
here's Refinery helper
https://github.com/resolve/refinerycms/blob/master/core/lib/refinery/helpers/html_truncation_helper.rbwhich uses that plugin.

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms-blog/issues/98#issuecomment-1524859

[ugisozols]

By taking a quick look at truncate_html specs https://github.com/hgimenez/truncate_html/blob/master/spec/truncate_html/html_string_spec.rb#L10-16 it's clear that removing continuous whitespace is intended behavior.

Dunno about line breaks as I haven't looked any further yet.

[parndt]

@joemsak @ugisozols @astjohn status?

[astjohn]

@parndt, as ugisozois has pointed out, whitespace is intentionally removed by the truncate_html gem. This effectively breaks the ability to use code and pre blocks.

For my own personal use, I have since disabled the teaser functionality. Either refinerycms-blog will have to roll it's own solution, or the gem will have to perhaps add an option to preserve whitespace. Unfortunately, I don't have time at the moment to contribute.

[ugisozols]

I haven't looked into this issue any further... should I?

[parndt]

@ugisozols sure if you like, the best option might be to contribute a patch to truncate_html that allows an option for preserving whitespace.

[parndt]

Any failing test would do too

[budu]

@astjohn how do you disable teasers?

[astjohn]

@budu, Unfortunately, it's been a while and I have moved away from refinery. At the time, I believe I ended up removing anything that would have rendered them while I customized the views. Not ideal.

[parndt]

I think an acceptable workaround is to enter content into the custom_teaser field :-)