adding a tag to a page breaks Blog/posts#index about refinerycms-blog

[ugisozols]

Can you try latest version 1.6.2?

[joemsak]

If you upgrade to the latest version of the blog and run the generator (rails g refinerycms_blog) and make sure you're not using an overridden version of that file (according to your path you're not)

But yea, you need 1.6.2, it fixes this bug in 1.6.1

I just created a test blog, added my first article, put a tag on it, went to view it and it blew up. If I take the tag off then it works. If I view the page directly via "view this blog post live" then it displays OK even with a tag.

The problem seems to be when viewing the index of articles, not a single article. Here's the error message

beginning of paste <<<<<

Showing /usr/lib/ruby/gems/1.8/gems/refinerycms-blog-1.6.1/app/views/blog/shared/_post.html.erb where line #18 raised:

undefined method `name' for "vim":String
Extracted source (around line #18):

15: <% if (tags = post.tag_list).any? %>
16:

17: <%= t('tagged', :scope => 'blog.posts.show') %>
18: <%=raw tags.collect { |tag| link_to tag, tagged_posts_path(tag.id, tag.name.parameterize) }.to_sentence %>
19:
20: <% end %>
21:
Trace of template inclusion: /usr/lib/ruby/gems/1.8/gems/refinerycms-blog-1.6.1/app/views/blog/posts/index.html.erb

end of paste <<<<<<<

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms-blog/issues/95

[JohnSmall]

OK, thanks I was reading the instructions on the install page where it says

Open up your Gemfile and add at the bottom this line:

gem 'refinerycms-blog', '~> 1.6.1'

You need to update that.

Anyway I worked out what the error was (tags = post.tag_list).any? should be (tags = post.tags).any?

But the 1.6.1 code must be failing in the Cucumber scenario which says

Scenario: The blog has a "tagged" route & view
Given there is a blog post titled "I love my city" and tagged "chicago"
When I visit the tagged posts page for "chicago"
Then I should see "Chicago"
And I should see "I love my city"

Because 1.6.1 also barfs when listing articles for a tag. Which would imply 1.6.1 was released with a failing scenario.

How do I run the tests? And how do I change the code on this stuff without having to re-install the gem?

Thanks for the quick response.

John Small

[JohnSmall]

Ah right, getting a version that fixes the bug, i.e. 1.6.2 requires a new version of Refinerycms 1.0.3 and a new version of Rails 3.0.9.

Which is very naughty. It should be possible to get a bug fix in without having to go through a whole long chase of dependencies, which might mess up the set up of people using the bloging engine.

As a courtesy could you please make sure that bug fix releases have the same dependencies as the code they're fixing. New feature releases are OK for changing the dependencies. If 1.6.2 is a set of bug fixes for 1.6.1 it should have the same dependencies. If it does more than fix bugs, i.e it adds features then it should go up to 1.7.0. Please try to keep bug fix releases separate from new feature releases.

[parndt]

Unfortunately 1.6.2 required 1.0.3 for bugfix reasons.