Coder Social home page Coder Social logo

Comments (7)

tombujok avatar tombujok commented on July 23, 2024

So you would like to be able to edit the Manifest.MF file of an artifact that's already a bundle without using the 'override' option - basically without bundling it once more using BND? Do I get it correctly?

What do you mean by the "bnd prevent instruction"?

from p2-maven-plugin.

nachtgold avatar nachtgold commented on July 23, 2024

Yes, I want to change only the file name and the bundle symbolic name manifest element.

Like

<artifact>
     <id>org.apache.log4j:com.springsource.org.apache.log4j:1.2.16</id>
     <transitive>false</transitive>
     <bundled>true</bundled>
     <instructions>
        <Bundle-SymbolicName>org.apache.log4j</Bundle-SymbolicName>
     </instructions>
</artifact> 

This "bundled" setting prevent the normal BND bundle process and only the specified instructions will be executed (like changing the manifest imports or exports).

from p2-maven-plugin.

tombujok avatar tombujok commented on July 23, 2024

The 'bundled' switch is not a good idea since there is already the 'override' switch.
It would have to be then:
override -> bundle
override -> manifest

I just do not get the business case why you would like to rename the bundles...
Forgeting p2 and OSGi - you cannot add a dependency in the pure maven renaming it at the same time...

from p2-maven-plugin.

nachtgold avatar nachtgold commented on July 23, 2024

My case is: I need org.apache.log4j:1.2.16 as dependency and spring source already offers a bundle (in their maven repo). But I do not find this bundle in a public P2 repo (only v1.2.15), so I want to host it myself.

from p2-maven-plugin.

nachtgold avatar nachtgold commented on July 23, 2024

I found https://svn.apache.org/repos/asf/logging/log4j/tags/v1_2_16/pom.xml so I use the same BND instructions and the result matches.

from p2-maven-plugin.

tombujok avatar tombujok commented on July 23, 2024

Perfect. Thanks

from p2-maven-plugin.

nachtgold avatar nachtgold commented on July 23, 2024

Wow, if the BSN in the manifest already is correct, then your plugin changes the file name correctly. This saves a lot of work.

Sample: http://repo1.maven.org/maven2/net/java/dev/glazedlists/glazedlists_java15/1.8.0/glazedlists_java15-1.8.0.jar

groupId and artifactId are useless, but so I have to do anything. Thx 👍

from p2-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.