Coder Social home page Coder Social logo

Comments (3)

mbrubeck avatar mbrubeck commented on July 21, 2024 1

Fixed in bfabcc9. However, this has limited use because:

  1. It is implemented only for NotNan<f32> and NotNan<f64>. Implementing it for a generic T would be incorrect because T could implement Hash in a way that is inconsistent with NotNan::hash.

  2. This isn't useful for HashMap::get or BTreeMap::get, because f32 and f64 do not implement Hash or Ord themselves.

from rust-ordered-float.

mbrubeck avatar mbrubeck commented on July 21, 2024 1

Unfortunately, I think that fails for the same reason. BTreeMultiMap::<K, V>::range has the following signature:

    pub fn range<T: ?Sized, R>(&self, range: R) -> MultiRange<'_, K, V>
    where
        T: Ord,
        K: Borrow<T>,
        R: RangeBounds<T>,

When K = NotNan<f32>, R = Range<f32>, T = f32, this fails the T: Ord bound.

from rust-ordered-float.

changhe3 avatar changhe3 commented on July 21, 2024

I think this is useful for the extremely rare cases where you use float as keys for range queries in data structures like btreemultimap.

from rust-ordered-float.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.