Error in advlib-ble-manufacturers/lib/pur3ltd.js about advlib-ble-manufacturers

[m-murillo]

Hello.

By mistake I closed the issue, sorry.

I updated the node v8.10.0 to v16.18.0.

I still have the same errors without the code I added before.

• In the example of README.md (hello advlib-ble-manufacturers) it returns null.
• In advlibblemanufacturers.test.js:

describe('advlib-ble-manufacturers', function() {
^

ReferenceError: describe is not defined
    at Object.<anonymous> (/home/.../node_modules/advlib-ble-manufacturers/test/unit/advlibblemanufacturers.test.js:29:1)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

Thank you.

[m-murillo]

Hello again!

I was watching where was the mistake in the example of README.md (hello advlib-ble-manufacturers) and it's on function processIBeacon (/home/.../node_modules/advlib-ble-manufacturers/lib/apple.js:75). It seems the variable isInvalidLength = true because:

let isInvalidLength = (data.length !== IBEACON_FRAME_LENGTH) || //22 !== 23 (true)
                                 (data.readInt8(FRAME_LENGTH_OFFSET) !== IBEACON_LENGTH); // 0 !== 21 (true)
if(isInvalidLength) {
    return null;
}

So it returns null in consequence.
Sorry if I split the problem, but I'm working on it.

Thank you.

[jeffyactive]

Hi @m-murillo, you have indeed found a problem with the example on the README.md: the manufacturerData variable was missing a byte, and hence the library returned null when processing, as it should. Sorry for the trouble this has led you to!

The example on the README.md has been updated, and with the updated manufacturerData you should see an output of:

{
  deviceIds: [ '00112233445566778899aabbccddeeff/0123/4567' ],
  txPower: -4,
  uri: 'https://sniffypedia.org/Organization/Apple_Inc/iBeacon/'
}

Please confirm and close the issue if that works for you. Note that you may wish to instead use advlib with advlib-ble-manufacturers as a library, as this is the more common use case. Thanks!

[m-murillo]

Hello jeffyactive!

It works, thank you so much.