Comments (4)
Is the problem that type
cannot be inferred here?
declare function unionArg(
x: { type: 'FOO' } | { type: 'BAR'; x: number } | (() => void)
): void;
// type is any when hovering in vscode?
unionArg({type: })
I do not think this is an issue with redux-thunk. It is a usability issue with typescript, because the types are correct.
from redux-thunk.
@laat The key point is not that the type of type
property is any, but when you typing the type
attribute, there is no type hint.
declare function unionArg( x: { type: 'FOO' } | { type: 'BAR'; x: number } | (() => void) ): void; // type is any when hovering in vscode? unionArg({type: })
However, the code you provided will prompt you when you typing the type
attribute.
from redux-thunk.
I see, yes I can reproduce it. It's strange that it is aware of the types, but unable to complete.
from redux-thunk.
I spent some time today playing around with this. Loosely put, if I try rearranging the overloads, I can get correct inference for type
here, but some of our other typetests fail.
This is an edge case anyway. We generally expect that A) the thunk middleware will not be typed to be restricted to a specific set of dispatchable actions (per https://redux.js.org/usage/usage-with-typescript#avoid-action-type-unions ), and B) users won't normally be hand-writing a type
field in a plain action object as they dispatch because they'll be using action creators.
Given that, I don't think this is something we're going to fix, unless someone else comes up with a way to rearrange the types without breaking things.
from redux-thunk.
Related Issues (20)
- Why `redux` module extension is not part of index.d.ts file in package? HOT 1
- Passing `dispatch` instead of calling it.
- Empty payload in PENDING state HOT 1
- Why not next? HOT 1
- types wrong by infer in TS HOT 1
- import 'redux-thunk/extend-redux' doesn't work HOT 12
- When running server getting expected errors HOT 2
- ThunkAction is not assignable to parameter of type 'AnyAction'. HOT 46
- Current implemention doesn't allow Jest or any other mock tool to spy on dispatch or getState HOT 2
- TS do not show the error if payload is Partial<> HOT 1
- Can I abort redux thunk dispatches? Without Redux toolkit or aborting the fetch request itself. HOT 1
- Allow wrapped thunk actions for extensibility HOT 2
- When type: "module" is used in root package.json, redux-thunk cannot be applied without crashing HOT 8
- Warning in React-thunk while installing HOT 1
- Query About Redux Thunk HOT 1
- `thunk` as a named export? HOT 3
- redux thunk cannot be use as middleware using Typescript 5.0 or above HOT 1
- during integrating thunk into react-redux project, getting middleware is not a function error. HOT 1
- No default export for redux-thunk HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-thunk.