Comments (8)
Let's get a PR 🎉
from redux-json-api.
Ill try to get to it tonight, some RL stuff came in the way.
Scratch that, ill have a look in the weekend.
from redux-json-api.
@Nopzen Had a chance to look at this?
from redux-json-api.
@egeriis Sorry no. I'll try to take a look asap, i got to open some codebase today where i use this.
from redux-json-api.
@egeriis so i can see i just use a very basic example:
store.dispatch(setAxiosConfig({
baseURL: 'http://localhost:3000/'
}));
And as i can see out of the code here:
https://github.com/redux-json-api/redux-json-api/blob/master/src/jsonapi.js#L194
[API_SET_AXIOS_CONFIG]: (state, { payload: axiosConfig }) => {
return imm(state).set(['endpoint', 'axiosConfig'], axiosConfig).value();
},
We are basically on the key endpoint setting the given Axios config given as param to the action.
My assumtion here is we can pass a config as the given example of the Axios repo: https://github.com/axios/axios#axioscreateconfig? So supporting: baseurl
, timeout
& headers
?
Also i wonder why is it stored on a key called endpoint
should it not just be axiosConfig
??
from redux-json-api.
Yeah, the configuration you provide are directly proxied to axios.
Also i wonder why is it stored on a key called
endpoint
should it not just beaxiosConfig
??
Legacy. We used to have endpoint and base path specified here. Feel free to move it. Should not break anything.
from redux-json-api.
I think I just discovered that we haven't documented the new resolve value from readEndpoint
, i.e. that it now returns an ApiResponse
instance.
from redux-json-api.
So okay I'am back on track now.
So i, working on this PR again and for now i will update the documentation on how to get going, and setting up the axios config.
And on this comment form @egeriis
Legacy. We used to have endpoint and base path specified here. Feel free to move it. Should not break anything.
I investigated it broke a lot by removing the endpoints
key, i expected this, but I've refactored it to a working state again, and are no building tests for this use case, meanwhile i explored this refactor i discovered we didn't have test cases for the redux-thunk actions, these are the one i will create a bare minimum test cases that covers my refactor.
The test setup will include as of now installation of package Chai, and moxios (mocking axios), i hope to have a pr soon.
Sorry for the delay of things.
from redux-json-api.
Related Issues (20)
- Workwith Immutable.js HOT 1
- Best Practice for 422 or 500 Errors HOT 2
- Could you guys give me an example of using json-redux-api with Axios? HOT 17
- Update hydrateStore doc example
- resource.type vs collection endpoint uris HOT 5
- Add flow-typed
- Delete resource endpoint appears to use relative pathing HOT 5
- Links to state HOT 5
- Update state at next readEndpoint HOT 3
- Custom URL construction HOT 11
- Action type is undefined HOT 4
- Pagination URLs can be objects.
- Unable to start expo due to Node standard library dependency of keykey HOT 1
- angular @angular-redux process not defined HOT 6
- babel-runtime must be added manually to build
- Media Types (Content Negotiation) for mutlipart/form-data content type. Request for implementation. HOT 1
- Is there any known live fork of this repo? HOT 2
- getRelatedResources crashes if relationship data is null HOT 2
- Export instance of axios that used in requests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-json-api.