Coder Social home page Coder Social logo

Comments (8)

moliware avatar moliware commented on June 28, 2024

Thanks for reporting it, I will do this change as soon as possible.

I'm working in doing mysolr compatible with 4.0 for the next realese :)

from mysolr.

moliware avatar moliware commented on June 28, 2024

I don't know how to handle the version. Maybe it's a good choice passing it as a parameter or maybe we can call /solr/admin/system?wt=json endpoint at init time.

What do you think @rabad, @dmarko484?

from mysolr.

dmarko484 avatar dmarko484 commented on June 28, 2024

Would prefer parameter, its more clear to me ...

from mysolr.

rabad avatar rabad commented on June 28, 2024

I would also vote for the parameter. @moliware, maybe we could also add a flag to the constructor to allow mysolr to retrieve the version?

from mysolr.

moliware avatar moliware commented on June 28, 2024

f you agree, we can use a version parameter set to None by default. If we receive the version we use it, if not we retrieve it from the endpoint.

Sounds good?

from mysolr.

rabad avatar rabad commented on June 28, 2024

Yep. Let's go for it.

from mysolr.

dmarko484 avatar dmarko484 commented on June 28, 2024

Yes, nice ...

from mysolr.

moliware avatar moliware commented on June 28, 2024

Done

from mysolr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.