Comments (6)
Yes, I have that pending. The problem is that there are many unused variables that aren't a problem as I only use them to instantiate function and don't use the results. I could create a macro unused_variable or something like that to avoid it. It certainly needs fixing. I'll address this one right away
from hlslpp.
Fixed via 3305152
from hlslpp.
I've made a bug here so you can track it for the future #70 (comment)
from hlslpp.
Thank you! I found this particular error during compilation of my project with HLSL++ 3.3. It was a problem of HLSL++ upgrade to v3.3 because my project is using maximum compilation level. I just want to clarify that I don't really care about unused variables in the unit tests of HLSL++, but it's extremely important to have zero warnings and errors in main headers of the external libraries.
from hlslpp.
Yes, I agree. What I mean is that I cannot promote warnings as errors just yet because there are many false positives that come from the unit tests. I have been a bit careless in that regard. I'll see if I can find some time this weekend to do something about it, or incrementally take care of it. Thanks for your continued help. I've created 3.3.1 in case you feel more comfortable upgrading to releases
from hlslpp.
Thanks! It's really more convenient to upgrade to releases for me since I use CPM.cmake for external library management, which pulls library sources by version/tag.
Btw, if you're building unit tests with C++17 you may use [[maybe_unused]] attribute to ignore those unused variables.
from hlslpp.
Related Issues (20)
- Integer vector division is working incorrectly on Macs with Apple M1 (ARM) HOT 7
- Integer vector comparison is working incorrectly on Intel based Macs with MacOS >= 11 HOT 3
- Improve HLSL++ unit tests by using full-featured testing framework HOT 2
- Matrix accessor operator HOT 6
- operator / (float1, float3) looks inverted HOT 8
- How well does this cover HLSL202x? HOT 11
- * operator brake mult function in quaternion HOT 7
- Quaternion slerp returning nan values HOT 2
- Upgrade warnings to errors HOT 2
- round() on ARM Neon uses wrong rounding mode HOT 2
- mul() intrinsic is missing some overloads. HOT 2
- clamp() intrinsic is missing overloads for intN HOT 1
- Some non square matrix definitions are incorrect HOT 6
- Missing matrix constructors HOT 2
- Some vector double functions missing HOT 5
- Undefined behavior when accessing vector elements with operator[] HOT 10
- internal::round_float gives incorrect results HOT 4
- Build failure on G++13.2 HOT 11
- Errors on building Linux ARM64 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hlslpp.