Comments (7)
Hi @sandroci, Thanks a lot for raising the issue. The reason why we left those out is to keep the dependencies limited but since numpy being the first-class datatype in redisai python client now, it makes sense to add that into the dependencies. Can you open a PR, please (It might require some cleanups as well, like the exception check for numpy import error needs to be removed and probably there are others)?
from redisai-py.
Hi @hhsecond
Thank you for your fast reply 👍 I will create the PR during this week including the cleanup like removing the mentioned exception check and I will lookout for other obsolete checks.
from redisai-py.
Hi @sandroci,
I am pushing another version of redisai-py today or tomorrow. Did you get a chance to do this?
I'll be happy to merge if you made this already else, I'll add this also to my PR and merge. Let me know what works for you
from redisai-py.
Hi @hhsecond
I have made the small fix and opened the PR. I saw now that my Black formatter (https://github.com/psf/black) has reformatted the code. If this should be a problem and creates inconsistencies with your code style, I will remove the formatting 😃
from redisai-py.
Hi @hhsecond
Any news about my PR? Looking forward to complete all necessary steps to make it mergeable.
Best regards,
Sandro
from redisai-py.
@sandroci Sorry it took a bit. I just submitted my review with change requests. Once you could finish that, we are good to merge
Thanks,
S
from redisai-py.
Closing because of inactivity
from redisai-py.
Related Issues (20)
- Failing to store models in container HOT 2
- Is there a proper way to retrieve a tensor from the cache? HOT 1
- Use native `decode_responses` argument to decode
- Client Authentication Timing Out HOT 4
- Response error for pytorch HOT 2
- Issues with FLOAT tensors HOT 2
- sklearn onnx - expected 2 outputs but got 1 HOT 1
- Add CONTRIBUTOR guideline
- DAGRUN is not working with RedisAI 1.2.1 HOT 5
- modelset chunk size should be configurable HOT 2
- add script run to DAG
- add support for SCRIPTEXECUTE
- add support for DAGEXECUTE
- Enable postprocess on dag
- Pass transaction and shard hints into pipeline when set.
- add bool tensor support
- add string tensor support
- Python 3.10 Support HOT 1
- Bulk get tensors HOT 2
- How to use redisai client in redis cluster environment?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redisai-py.