Crucial dependencies are missing - can't use redisai module about redisai-py

[hhsecond]

Hi @sandroci, Thanks a lot for raising the issue. The reason why we left those out is to keep the dependencies limited but since numpy being the first-class datatype in redisai python client now, it makes sense to add that into the dependencies. Can you open a PR, please (It might require some cleanups as well, like the exception check for numpy import error needs to be removed and probably there are others)?

[sandroci]

Hi @hhsecond
Thank you for your fast reply 👍 I will create the PR during this week including the cleanup like removing the mentioned exception check and I will lookout for other obsolete checks.

[hhsecond]

Hi @sandroci,
I am pushing another version of redisai-py today or tomorrow. Did you get a chance to do this?

I'll be happy to merge if you made this already else, I'll add this also to my PR and merge. Let me know what works for you

[sandroci]

Hi @hhsecond
I have made the small fix and opened the PR. I saw now that my Black formatter (https://github.com/psf/black) has reformatted the code. If this should be a problem and creates inconsistencies with your code style, I will remove the formatting 😃

[sandroci]

Hi @hhsecond
Any news about my PR? Looking forward to complete all necessary steps to make it mergeable.
Best regards,
Sandro

[hhsecond]

@sandroci Sorry it took a bit. I just submitted my review with change requests. Once you could finish that, we are good to merge

Thanks,
S

[hhsecond]

Closing because of inactivity