document that getset kills key expirations about redis-io

[itamarhaber]

Hello @mlissner - thanks for bringing this up.

I couldn't find where the getset documentation code is

https://github.com/redis/redis-doc/blob/master/commands/getset.md

I know getset is now deprecated

Indeed, it is deprecated in favor of the all-in-one evolved SET command. That said, "deprecated" means very little here because I don't see us removing it from the project in the foreseeable future :)

so apparently this is something that has come up before

If you read the docs about SET, you'll find that it resets TTL (and doesn't care about the TYPE of the key if it exists). The KEEPTTL option was added recently to modify this behavior. Because GETSET also does a SET, it is implied that it also resets the TTL.

Would it be a good idea to put a note about this

Sure. Please make the PR that clarifies this and close this issue.

[mlissner]

Just created redis/redis-doc#1570 by copying from the SET documentation. Thanks for the guidance.

[mlissner]

Looks like this small change to the docs got dropped. Any chance we can merge it?

[zuiderkwast]

Merged. Thanks @mlissner! This issue can be closed.