hgetall returns {} when no results about node-redis

[mranney]

No, I just ran into this exact situation in my own app, and it's annoying. I'll fix it soon. Thanks for reporting.

[pietern]

Shouldn't this behave just as an empty multi bulk returning an empty array?

[mranney]

It's tricky, because JavaScript considers the empty object to be "truthy".

Now that I think about it though, returning null in this case will break people who do Object.keys(res). Hmm, hard to say which is best.

[pietern]

HGETALL always returns a multi bulk with length >= 0 and error replies are given via the error argument. This implies that you would be able to safely call:

if (result.length)

Right?

[cloudhead]

Well, it won't return an error, just an empty set... so the only way to check if it exists is to do if (Object.keys(reply).length), or check if it has a known property.

[cloudhead]

If we're trying to be very idiomatic, the current behaviour is best. If we want to be practical, I'd say either error should be non-null, or the reply should be null.

[mranney]

I guess we should just endure the breakage and send back null for an empty reply. Calling Object.keys on an untested value is risky for exactly this reason.

[mranney]

I finally went and landed this change. Sending back null is the less surprising thing, given than JavaScript treats an empty object as truthy.

Apologies to anybody that gets burned by the change in behavior.