idiomatic HMSET about node-redis

[mranney]

Yeah, that sounds like a good idea. Someone already contributed that syntax for HMGET, and it is indeed nicer. If you'd like to contribute an HMSET implementation that works like this, it would certainly get in faster. Otherwise, I'll put it on the list.

[jensenchen]

Alright. I tried. Here is the code I borrowed from bnoguchi's redis-node:

RedisClient.prototype.hmset = function (key, hash, callback) {
var args = ["hmset", key];
for (var property in hash) if (hash.hasOwnProperty(property)) {
args.push(property, hash[property]);
};
if (callback) args.push(callback);
this.send_command.apply(this, args);
};

Any Comments?

[mranney]

This turned out to be a lot more involved than I thought, but I just put this into v0.5.0:

ccce845#L2R481

Let me know if it works for you.