Improve pipelining by queueing commands about jedis

[xetorthio]

Not sure what do you mean. Right now pipelining in handled as it is handled by most of the clients.
You just keep sending commands without waiting and reading replies. And when you finish sending commands you read all the replies.
Today this increases performance from 23k of ops to 140k of ops, which is a HUGE boost.
If you need more info about how to do pipelining with Jedis you can find it here: https://github.com/xetorthio/jedis/wiki under Pipelining

Let me know if I misunderstood anything. Thanks!

[costin]

My understanding is that one could issue multiple commands in the same write to the server rather then doing multiple write operations. I haven't seen that happening in Jedis but maybe I've missed something.

On the same topic, the current API requires a 'callback' approach in which one adds all the commands in the JedisPipeline class which then executed by Jedis. For our use case, we're interested in having something like:

• start pipeline
• do op
• do op (and so on)
• stop pipeline

We don't have any control over the client so we'd like to enable batching/pipelining - invoke the client and then disable pipelining once returned. Currently we can't do that.
Could you improve the API so the workflow mentioned above could be supported?
Something like startPipelining/Batch ?

Thanks,

[costin]

Sorry - seems that I accidentally closed the issue while submitting my previous comment - that wasn't my intention.

[xetorthio]

I think we are OK with the pipelining approach. But it you have in mind how you can improve it, I will be more than happy to receive a pull request or even discuss in more details you solution :)

And regard the pipelining usage. Maybe I could add something like it is in multi, where you can provide a callback or get a Transaction and work on that. It will be like this:

Pipeline p = jedis.pipeline();
p.set("foo", "bar");
p.get("something");
List results = p.close();

Is that OK?

[costin]

That would be great. I guess you could create a common interface to avoid duplicating all the methods all over between Jedis/Transaction and Pipeline.
Cheers,