[Feature Request] namespace (or key_prefix) option about redis-rack

[tubbo]

I think the intention is that you should be able to call

Redis::Rack::Connection.new(redis_server: { url: 'redis://localhost/0', namespace: 'foobar' })

but if I'm reading this code right, having any DB in the path might cause that to be overridden. So I think checking whether a / appears in the path should suffice in allowing the above configuration and still supporting URLs like

Redis::Rack::Connection.new(redis_server: 'redis://localhost/0/foobar')

[tubbo]

update: The above code I posted does seem to work. Here's a quick test I wrote in redis-store to ensure that whatever you pass into :redis_server will be used as the arguments to Redis::Store::Factory.create. So you should be able to use the right namespace here while still providing an IANA-standard Redis URL:

diff --git a/test/redis/store/factory_test.rb b/test/redis/store/factory_test.rb
index cacd653..000645f 100644
--- a/test/redis/store/factory_test.rb
+++ b/test/redis/store/factory_test.rb
@@ -40,6 +40,12 @@
       it "uses specified namespace" do
         store = Redis::Store::Factory.create :namespace => "theplaylist"
         store.to_s.must_equal("Redis Client connected to 127.0.0.1:6379 against DB 0 with namespace theplaylist")
+
+        store = Redis::Store::Factory.create(
+          url: 'redis://127.0.0.1:6380/2',
+          namespace: 'foo'
+        )
+        store.to_s.must_equal("Redis Client connected to 127.0.0.1:6380 against DB 2 with namespace foo")
       end

       it "uses specified key_prefix as namespace" d

[mtgto]

@tubbo Thank you for your kindy explanation. 😃

I think the intention is that you should be able to call
Redis::Rack::Connection.new(redis_server: { url: 'redis://localhost/0', namespace: 'foobar' })

It code works!
I apologize for my lack of research of your source code 🙇

---

As a matter of fact, I wanted to use redis-rack from redis-actionpack.
I use shared redis-server which used by some server softwares.
I need to set key prefix to distinguish which keys is created by.
But I can't find the doc in redis-actionpack, redis-store and redis-rack how to define key prefix.
Thus I post this issue.

For now, my config/initializers/session_store.rb can define namespace (key prefix) not violating IANA-standard Redis URL.
Example:

Rails.application.config.session_store :redis_store,
  servers: {
    url: ENV['REDIS_SERVER_FOR_SESSION'],
    namespace: 'my_server',
  },
  expire_after: 1.day,
  key: '_my_server_session',
  threadsafe: true,
  secure: Rails.env.production?,
  httponly: true