Coder Social home page Coder Social logo

Comments (4)

raffaelespazzoli avatar raffaelespazzoli commented on May 24, 2024

should this be added to the helm chart or created by the operator when it starts?

from cert-utils-operator.

OchiengEd avatar OchiengEd commented on May 24, 2024

It should not matter where it is added. It however makes sense to create the ServiceMonitor after the metrics service.

An example would appear as shown below.

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: cert-utils-service-monitor
  labels:
    role: metrics-sink
spec:
  selector:
    matchLabels:
      name: cert-utils-operator
  endpoints:
  - port: http-metrics

from cert-utils-operator.

silverbp avatar silverbp commented on May 24, 2024

This should have been done in helm with a default of not installing it to follow other community standards that have already been set on this. The code is making an assumption that you are using Prometheus in your k8s cluster, if you are not, the code fails and is unusable. If you are going to do this in code even though this is largely done in the helm chart with a flag, it should at minimum be configurable.

from cert-utils-operator.

raffaelespazzoli avatar raffaelespazzoli commented on May 24, 2024

I agree.
@trevorbox would you be able to fix this?

from cert-utils-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.