Comments (6)
Hey, can you assign this to me?
from ofrak.
Hi @The-Debarghya, I've assigned you this issue. To make this change, you will likely have to change some subprocess.run
calls in OFRAK components, as well as changing installed dependencies in one of the Dockerstub
files.
Make sure to look at the contributing guide. Thanks for your interest in helping out!
from ofrak.
I'm struggling to figure out where to change the subprocess.run
calls in the OFRAK components...can you please help me out.
Also should I change docs and object names that refer to gzip or p7zip?
from ofrak.
7z
is run in two places:
- https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components/p7zip.py#L48
- https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components/p7zip.py#L68
Variables using the name p7zip
should be updated to use 7zip.
Instructions/code that installs p7zip
should also be updated to install 7zip:
- https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/Dockerstub#L12
- https://github.com/redballoonsecurity/ofrak/blob/master/docs/environment-setup.md?plain=1#L184
You can test the changes by running the following test: https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components_test/test_p7zip_component.py. The test file might need to be updated as well.
Hope this helps!
from ofrak.
p7zip variables can't be renamed to 7zip because python doesn't permit variable name starting with an integer, so should I name it like this: _7zip or maybe sevenZip?
and for the filenames...I'm renaming them to 7zip.
from ofrak.
Either sevenzip
or seven_zip
probably make sense (based on https://peps.python.org/pep-0008/#function-and-variable-names).
Regarding the filenames that sounds fine.
from ofrak.
Related Issues (20)
- java is_tool_installed() not working correctly. HOT 2
- Improve CPIO (and other archive) packer/unpacker pairs using `libarchive`
- angr install not working on 3.7 because of z3-solver issue
- Dragging binary into the GUI does not work
- ESP Unpacker
- Updating ResourceView attributes is unintuitive. HOT 1
- Adding Flare-Floss String Analysis support
- Circular dependency cases a `make develop` weirdness. HOT 2
- Cleaner OFRAK Documentation install in Docker image HOT 1
- ImportError: cannot import name 'KS_ARCH_ARM64' from 'keystone' in Apple Silicon M1 HOT 6
- Strings with slashes cause FileNotFoundError HOT 1
- crashes when checking for missing dependencies HOT 4
- Lief modifiers should support PE files.
- Installation of Binary Ninja fails due to change in package name HOT 1
- `Resource.get_attributes`: incorrect documentation HOT 3
- Bundle OFRAK docs so they always match GUI version
- Import/export existing Ghidra project into OFRAK HOT 1
- ofrak-ghidra works with server that user can access directly
- Generate report from OFRAK project
- Add support for multiple comments on the same Range
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ofrak.