Coder Social home page Coder Social logo

Comments (2)

LoganDark avatar LoganDark commented on June 6, 2024 1

Now, I can use stopPropagation correctly and the keybinds all still work - but callback is called twice with every keypress. What?

This was a combination of two things:

  • I forgot to use useCallback in a parent component, causing the hotkeys to get regenerated every render.
  • All the hotkeys were hidden, and as a shortcut I used the same name, but for some reason that caused useHotkeys to stop functioning correctly, in the same manner that React needs unique keys on components in a list. The hotkeys wouldn't be unregistered properly, causing duplicate hotkeys to exist with even more of the same name, amplifying the issue.

In the end I was able to fix this. The full solution to suppressing outside keybinds:

  1. Make sure ref is an object with a current property.
  2. Add your own keydown handler to the element that calls stopPropagation on every event.
  3. Use a focus trap and make the entire element focusable via tabIndex={0} to keep the Mousetrap and stopPropagation functional

from reakeys.

LoganDark avatar LoganDark commented on June 6, 2024

Okay, so it looks like this is a bit of user error - ref only works if it is passed an object with a current field... which means I have to do this

	const [menu, setMenu] = useState<HTMLDivElement | null>(null)
	const menuRef = useMemo(() => ({current: menu}), [menu])

since I have a useEffect that depends on menu.

Now, I can use stopPropagation correctly and the keybinds all still work - but callback is called twice with every keypress. What?

from reakeys.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.