Coder Social home page Coder Social logo

Comments (8)

 avatar commented on July 20, 2024 1

I submitted another fix which I think finally resolves this. Let me know if it doesn't and I'll re-open.

from vscode-reasonml.

kennetpostigo avatar kennetpostigo commented on July 20, 2024

@freebroccolo I realized the culprit is wrapping the function body in {...}

I take those away and everything is good, is this a difficult fix to make?

from vscode-reasonml.

 avatar commented on July 20, 2024

I suspect the issue may be related to the :: for punning which initially causes it to fail. What happens if you try something like paths::paths?

from vscode-reasonml.

kennetpostigo avatar kennetpostigo commented on July 20, 2024

@freebroccolo you are right, once I do that the highlighting returns. However refmt will automatically return it to the punned labelled arguments version.

from vscode-reasonml.

 avatar commented on July 20, 2024

Yeah, the syntax highlighting hasn't been updated for punned arguments yet. I was working on a rewrite of the syntax highlighting that is more accurate but I haven't had a chance to finish it yet. I'll try to spend some time on that next week.

from vscode-reasonml.

kennetpostigo avatar kennetpostigo commented on July 20, 2024

@freebroccolo Awesome!

from vscode-reasonml.

 avatar commented on July 20, 2024

@kennetpostigo Can you check if this is fixed for you now with the latest commit and whether you notice any new breakage? Just clone the repo, open repo director in code, and hit F5 to launch a development version of the extension, then try it on a file that was messed up before.

from vscode-reasonml.

 avatar commented on July 20, 2024

Looks like the fix I introduced needs a little more work actually.

from vscode-reasonml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.