Comments (8)
I submitted another fix which I think finally resolves this. Let me know if it doesn't and I'll re-open.
from vscode-reasonml.
@freebroccolo I realized the culprit is wrapping the function body in {...}
I take those away and everything is good, is this a difficult fix to make?
from vscode-reasonml.
I suspect the issue may be related to the ::
for punning which initially causes it to fail. What happens if you try something like paths::paths
?
from vscode-reasonml.
@freebroccolo you are right, once I do that the highlighting returns. However refmt will automatically return it to the punned labelled arguments version.
from vscode-reasonml.
Yeah, the syntax highlighting hasn't been updated for punned arguments yet. I was working on a rewrite of the syntax highlighting that is more accurate but I haven't had a chance to finish it yet. I'll try to spend some time on that next week.
from vscode-reasonml.
@freebroccolo Awesome!
from vscode-reasonml.
@kennetpostigo Can you check if this is fixed for you now with the latest commit and whether you notice any new breakage? Just clone the repo, open repo director in code
, and hit F5 to launch a development version of the extension, then try it on a file that was messed up before.
from vscode-reasonml.
Looks like the fix I introduced needs a little more work actually.
from vscode-reasonml.
Related Issues (20)
- Error starting reason-vscode "expected string", fix error message for invalid bsconfig.json HOT 1
- Options for ReasonML formatting?
- BSC.exe: Wrong Argument. -bs-jsx expects an integer HOT 4
- Incorrect problem matcher for ocaml >= 4.09
- Wrong module for "go to definition" HOT 3
- merlin error reporting can be excessive
- [Feature] Completion on labelled arguments
- Unable to run first ocaml "hello world" program.
- Double error/warning dislayed
- WSL: opam local switch environment
- What does this highlighting of a whole function mean?
- Ternary Operators are Highlighted as bool
- Restart Merlin? HOT 1
- Why is the highlighting for OCaml so weird?
- Node module errors preventing extension from working
- Autocomplete not working HOT 1
- OCaml: Incorrect syntax highligthing if identifier starts with let
- Request textDocument/formatting failed
- VS Code: we have marked your extension as deprecated HOT 3
- Hijacking Markdown code block highlighting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-reasonml.