Comments (3)
I wish that were possible. I haven't found a way to have Transform be Then and still compile.
If you can find a way to do this please fork the repo, make the change and submit a pull request.
I'd be very keen to have it work the way you suggest.
from c-sharp-promise.
Hi @ashleydavis,
I think #1 made possible refactoring Transform
to Then
. I did it on my version project and it worked with no compiler errors out of the box. I'll try to open the git repo by itself and refactor + pass some changes I made:
- I added a new
public Promise<PromisedT> (PromisedT value)
constructor to create a resolved promise, it seemed important because this is the monadic "Return" function. - Changed the internals of
Transform
(now called Then) to just "fallback" to the "bind"Then
using the new constructor like this:
public IPromise<ConvertedT> Then<ConvertedT>(Func<PromisedT, ConvertedT> f)
{
//Argument.NotNull(() => transform);
return Then((PromisedT t) => (IPromise<ConvertedT>)new Promise<ConvertedT>(f(t)));
}
I have experience with Futures/Promises since I made my own Futures library for the project, as far as I saw it worked perfectly but I decided to use your library once #1 was solved.
from c-sharp-promise.
I'll be really happy if you can get Transform changed to Then ;)
Please submit a PR when you are ready to get your change in.
from c-sharp-promise.
Related Issues (20)
- Feature Request: Promise retry HOT 2
- How to exit from then when check some conditions HOT 6
- Not Usable inside Tasks? HOT 3
- NuGet Package outdated since last improvements
- Cancelling a promise. HOT 1
- Default and custom error handler HOT 1
- GC caused by Closure HOT 3
- OpenUPM support. Unity Package Manager HOT 3
- A unsolved ambiguous compile error
- Compile Errors in Unity 2020.2.6f1 HOT 1
- For a complete noob... how and what do I import to my Unity project to start using this? HOT 1
- Different results for javascript.Promise and C-Sharp-Promise HOT 2
- Support .NET Standard and 3.5 into the same Unity project HOT 1
- Some general questions about handling promises HOT 3
- Promises are not Serializable HOT 1
- Need implicit casts between Promise<object> and Promise and interfaces HOT 3
- Catch from a Promise<object> returns IPromise instead of IPromise<object> HOT 2
- Promise Queue? HOT 2
- How can I get response data at the first stage HOT 7
- Create an Unity Package of this library HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from c-sharp-promise.