Comments (3)
Eviction predicates were initially offered as composable pre-built Functions
via EvictionPredicates
, but @nebhale and @smaldini argued against it because only the idle one was deemed useful, so it was removed in #10.
Coming up with a Predicate
that directly checks both idle and custom logic should be easy enough, though. Plus Predicate
composition is also always possible.
The idea of the two methods on the builder was that most of the time a simple idlePredicate
would be enough, but evictionPredicate(Predicate)
offers an escape hatch for more complex cases.
from reactor-pool.
I wonder if we need to keep the idle alias in fact as it might be more clear to just leave the user implement it (slightly more verbose ?)
from reactor-pool.
I'll clarify this behavior in the documentation, including the piece of code users can use to reproduce the evictionIdle
when combining this logic with some custom logic is needed.
from reactor-pool.
Related Issues (20)
- Possible pool resource release bug HOT 11
- Suppress CommonPoolTest#pendingLimitAsync(Function) onErrorDropped logging
- PoolMetrics.acquiredSize() is incremented too early HOT 1
- Missing SimpleDequePool.drain() when SimpleDequePool.cancelAcquire() HOT 1
- InstrumentedPool: better insights into pool inactivity HOT 1
- Constantly keeping 10 idle connections HOT 16
- Remove outdated issue template and Contributing.md
- Wrong pool metrics when invalidating an idle resource HOT 4
- Quiet period & timeout wait for waiting requests and active connections HOT 4
- Performance issue in SimpleDequePool class
- Soft eviction for in-use connections
- when I use spring cloud gataway,I find reactor.netty.internal.shaded.reactor.pool.AbstractPool.Borrower#request use a lot of cpu HOT 1
- Provide Micrometer PoolMetricsRecorder adapter HOT 3
- Add support to pool to do scheduled connection validation HOT 11
- Problems when warmup procedure and database query procedure running in parallel.
- `PoolMetrics.allocatedSize` reports a different allocation count when the allocator uses threads HOT 4
- Incorrect handling of allocator errors during "warmup" in SimpleDequePool HOT 1
- InstrumentedPool.PoolMetrics isInactiveForMoreThan mixes time units HOT 3
- Warmup procedure fails if warmups were found HOT 2
- pendingacquiretimeout is not working as expected HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactor-pool.