Coder Social home page Coder Social logo

Comments (5)

fkling avatar fkling commented on April 27, 2024

Mmh. Overall I would agree, but the added value doesn't really justify a breaking change. I'll leave this open for the next major version.

from react-docgen.

levithomason avatar levithomason commented on April 27, 2024

👍

from react-docgen.

mik01aj avatar mik01aj commented on April 27, 2024

@levithomason maybe you would consider using a tool like react-styleguidist that reads your examples from Markdown files? I personally like this approach more. Otherwise you might end up with huge comments in your source code, like here...

from react-docgen.

levithomason avatar levithomason commented on April 27, 2024

@mik01aj Thanks for the suggestion. I ended writing a gulp plugin that leverages react-docgen and eslint/doctrine for docblock parsing.

As for examples, we're writing and rendering our examples as regular React components. For the code snippet, we use webpack's raw-loader to read the text and highlight it with react-highlightjs. This is working pretty well for us so far.

EDIT
This is great because the example code snippets are written in their native format (rather than a doc string, or markdown). What is rendered is exactly what the consumer will use, including import statements since each example is it's own module.

You can see this result on the doc site for TechnologyAdvice/stardust.

from react-docgen.

fkling avatar fkling commented on April 27, 2024

Looking back at this, I don't think that a minor improvement in code aesthetics justifies a breaking change. You can always renamed the property yourself before you process it further.

I'm going to close this for now. If anybody feels really strongly about this, please let me know.

from react-docgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.