Comments (5)
Mmh. Overall I would agree, but the added value doesn't really justify a breaking change. I'll leave this open for the next major version.
from react-docgen.
👍
from react-docgen.
@levithomason maybe you would consider using a tool like react-styleguidist that reads your examples from Markdown files? I personally like this approach more. Otherwise you might end up with huge comments in your source code, like here...
from react-docgen.
@mik01aj Thanks for the suggestion. I ended writing a gulp plugin that leverages react-docgen and eslint/doctrine for docblock parsing.
As for examples, we're writing and rendering our examples as regular React components. For the code snippet, we use webpack's raw-loader to read the text and highlight it with react-highlightjs. This is working pretty well for us so far.
EDIT
This is great because the example code snippets are written in their native format (rather than a doc string, or markdown). What is rendered is exactly what the consumer will use, including import statements since each example is it's own module.
You can see this result on the doc site for TechnologyAdvice/stardust.
from react-docgen.
Looking back at this, I don't think that a minor improvement in code aesthetics justifies a breaking change. You can always renamed the property yourself before you process it further.
I'm going to close this for now. If anybody feels really strongly about this, please let me know.
from react-docgen.
Related Issues (20)
- react-docgen cannot extract comments with hermes-parser HOT 3
- Fow indexed access types results in `unknow` HOT 2
- useCallback + useImperativeHandle methods
- Expose more TypeScript types HOT 1
- react-docgen v6.0.0 & older changelogs HOT 2
- Property accessors as template literals causes errors with react-docgen v7 HOT 4
- Better TS enum support
- TS forwardRef support HOT 1
- With Typescript Omit Union types get lost
- With forwardRef Union types get lost HOT 1
- Internal server error: Argument must be Identifier, Literal, QualifiedTypeIdentifier or TSQualifiedName. Received 'TemplateLiteral' HOT 2
- Fails when a namespaced export is used HOT 1
- When postcss modules are present, in some scenarios react-docgen tries to parse css files HOT 2
- Typescript: Component props not parsed with 'call signature' type
- Typescript: Component declaration reference is not recognized by parser
- @defaultValue is not parsed from interface
- "Attempted to resolveName for an unsupported path" error HOT 2
- Decorators must be placed *after* the 'export' keyword. Remove the 'decoratorsBeforeExport: false' option to use the '@decorator export class {}' syntax.
- Using `Readonly<T>` utility type results in losing pieces of `T`'s information
- TypeScript: Missing Union Elements of Indexed Access Type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-docgen.