Coder Social home page Coder Social logo

Comments (11)

taggon avatar taggon commented on April 25, 2024 2

I think the third item should be "맞춤법 검사" rather than "띄어쓰기 검사", as the online tool checks more than spacing.

from ko.reactjs.org.

gnujoow avatar gnujoow commented on April 25, 2024 1
<!--

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->

**progress**  

[ ] 번역 초안 작성
[ ] glossary 용어 확인 (wiki or issue links)
[ ] 띄어쓰기 검사 (http://speller.cs.pusan.ac.kr/)
[ ] 리뷰 반영
[ ] 최종 PR

if this checklist included in template, I think this will be able to help contributors to check their tranlation progress.

from ko.reactjs.org.

gnujoow avatar gnujoow commented on April 25, 2024

for PR mege I suggest PR is merged if it has (at least) two approve from reviewer or maintainer to check the quality of the translation.

2019-02-12 10 50 40

from ko.reactjs.org.

taehwanno avatar taehwanno commented on April 25, 2024

for PR mege I suggest PR is merged if it has (at least) two approve from reviewer or maintainer to check the quality of the translation.

I agree :)

if this checklist included in template, I think this will be able to help contributors to check their tranlation progress.

Good idea. We need to add UNIVERSAL-STYLE-GUIDE.md in #17.

from ko.reactjs.org.

hg-pyun avatar hg-pyun commented on April 25, 2024

Yeah, It is a very coool idea.

from ko.reactjs.org.

cadenzah avatar cadenzah commented on April 25, 2024

The idea of progress items is pretty nice. It will be easier to check important stuffs.

from ko.reactjs.org.

taehwanno avatar taehwanno commented on April 25, 2024

I applied "Require pull request reviews before merging" with options in the screenshot.

from ko.reactjs.org.

simsim0709 avatar simsim0709 commented on April 25, 2024

I agree 👍

from ko.reactjs.org.

gnujoow avatar gnujoow commented on April 25, 2024

I will close this issue and make PR for PR templete this sunday. if there is any feed back on the checklist, comment on this thread by this week.

from ko.reactjs.org.

taggon avatar taggon commented on April 25, 2024

The current PR template, which introduced by #25, contains broken links. If we don't have appropriate references for the items yet, it would be better to remove the links.

image

from ko.reactjs.org.

gnujoow avatar gnujoow commented on April 25, 2024

@taggon I've just made pr to resolve the issue you mention.
#45

from ko.reactjs.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.