Hebrew Translation Progress about he.react.dev

[bvaughn]

Hm...looks like the "production branch" was configured incorrect in Circle for some reason. I've changed it to "master" and triggered a manual deployment since it's pretty stale. Should be okay now in a few minutes?

[rgrnwd]

Context & Forwarding Refs next 😃

[tesseralis]

Yeah! That should be translated.

[rgrnwd]

Can I translate Code-Splitting and higher order components?

[orrsteinberg]

Got it 👍 I'll get right on it then.

[gmadar]

• Home Page

[bentlusty]

@gmadar Added you to Home page. thank you!

[galtalmor]

• Tutorial

[galnir]

@galtalmor Added you to the tutorial

[galtalmor]

@gmadar Added you to the tutorial

Wrong mention, bug tagging is okay :)

[galnir]

@galtalmor oops sorry

[bromy]

• Hello World

[galnir]

@bromy It's yours 👍

[galnir]

Does anyone have a solution for fixing punctuation when translating into hebrew? There is an example in gmadar's pull request:

It also happens on my end when I translate sentences

[galtalmor]

Does anyone have a solution for fixing punctuation when translating into Hebrew?

I suppose it will just require some CSS tweaking with direction: rtl, but I'm not sure how would that work with the way they build and publish this website. I think it is best to try and contact someone from the team in charge to figure out if it is okay to make changes in the website's CSS since this problem will exist everywhere with this translation.

More specifically, adding the following code in the file algolia.css solved the basic issues for me, but requires more tweaking to make everything look better:

p, h1, h2, h3, ul, details {
  direction: rtl;
}

code {
  direction: ltr;
  display: inline-block;
}

[tesseralis]

@galtalmor It's definitely okay to make changes to the CSS -- Arabic and Persian dealt with the same thing and actually have PRs to do it: reactjs/ar.react.dev#8

You might want to post there to see if they can help you set it up for Hebrew!

[galnir]

@galtalmor A member of the Arabic translation team already helped us with that :) #6

[galtalmor]

@galtalmor A member of the Arabic translation team already helped us with that :) #6

👍

[dormd]

Awesome idea 😍
Rendering Elements

[galnir]

@dormd It's yours :)

[galtalmor]

• Getting Started

[itayyehezkel]

Introducing Hooks

[galtalmor]

Hey @bentlusty & @galnir I think you guys should update this main thread, it's starting to be hard to follow on what is already completed, what's not and who's working on stuff. I wouldn't mind helping with that if you guys are too busy. Thanks!

[galtalmor]

Here's the list of completed tasks with related PRs:

• Home Page (@gmadar) #4
• Hello World (@bromy) #8
• Tutorial (@galtalmor) #10
• tutorial/nav.yml (@galtalmor) #10
• LayoutHeader (@galtalmor) #11
• LayoutFooter (@galtalmor) #13
• docs/nav.yml (@galtalmor) #13
• Thinking in React (@galnir) #14
• Getting Started (@galtalmor) #15

[galtalmor]

• Components and Props

[galnir]

@tesseralis Can you please add @galtalmor as a maintainer? It would really help us keep up with the work

[tesseralis]

@galnir sure! In the future you can open a PR if you need to add more maintainers.

[tesseralis]

@galtalmor once you accept the invite to join the reactjs org you should be able to update this issue :)

[galtalmor]

@galtalmor once you accept the invite to join the reactjs org you should be able to update this issue :)

@tesseralis Yep, it works. Thanks!

[bromy]

As you are all working on these, I was wondering about what setup or process you are using in your text editor. Working with the mixed left-to-right/right-to-left text files made the formatting more of a challenge than it should have been 😄. Text kept jumping around, highlighting/copying/pasting felt unpredictable, and the markdown syntax was easily thrown off. Are there any editor or OS settings that made it more intuitive to work with the bidirectional nature of the text?

[galnir]

@bromy My main text editor is vscode, but it doesn't support right to left(in my experience). so for translation I use notepad++

[galtalmor]

@bromy I use WebStorm, it doesn't really support RTL (doesn't let you control it or stick the code to the right), but when the first word is in hebrew it kinda justifies the content in RTL, so it is good enough for me. Also it got a markup plugin that lets you see changes on the fly, so that is also pretty helpful.
I don't think there will be any really good solution here, but I will be happy to be surprised.

[dormd]

CDN Links

[itayyehezkel]

MarkdownPage

[dormd]

Composition vs Inheritance

[bentlusty]

Hey guys, I'm sorry I wasn't here as much as I should. Regrettably I don't have the time to maintain this repo.

See ya on rothschild boulevard :)

[dormd]

Hooks at a Glance

[galtalmor]

@tesseralis How often do languages websites get published? On the English website there's a link to the Hebrew version, but the Hebrew version was never published, the live version is all in English. Is there a way for us to publish a new version?

[tesseralis]

That's actually something that's confusing me too. The other languages are working properly -- I think it's just broken. Are you all publishing off the master branch? @bvaughn do you think you could look into this?

In the meanwhile, if you want something to work off, you could just create another netlify app and set it to the repo

[galtalmor]

@tesseralis @bvaughn Yes, now it seems to be working. Thanks!

[tesseralis]

We're almost done everyone!

@itayyehezkel @galtalmor what's the status of your pages?

Also, could anyone take the React.Component under "API"? It's the last of the core pages we need to do to mark this translation as complete!

[itzikya]

React.Component

[galnir]

@itzikya Added you!

[galtalmor]

Hey @tesseralis , I started a new job and had a few crazy weeks. I will complete the translation of my page soon and also review @galnir 's work. Cheers!

[rgrnwd]

Hey, I'm keen to contribute. I'll start with the Accessibility page, if that's ok with everyone? :)

[galnir]

@rgrnwd That's great, thanks!

[rgrnwd]

Can I pick up Error Boundaries next? Thanks!

[galnir]

@rgrnwd 👍

[galnir]

@tesseralis hey, should we also translate pages like 404/versions/acknowlegements?

[tsehori]

Hey, can I pick up Uncontrolled Components and React Without JSX?
Thanks!

[galnir]

@tsehori Ofc 👍

[tesseralis]

@itayyehezkel @galtalmor I'm going to open up your pages React and TestRenderer for now since it's been a while, so if anyone wants to take those pages to finish up the core translation, now's your chance!

@galnir I'm not sure which page that is? Do you have a link to the english react website for it?

[galnir]

@tesseralis
404 (page not found): https://reactjs.org/dhxnxdj

[tesseralis]

@galtalmor how is the API->React translation going? It's the last one we need to mark this as completed so we're eager to get that done!

[orrsteinberg]

Hey, I'd be happy to contribute. Is there anything that has high priority/that would be particularly helpful?
If not, I'll start with Passing Functions to Components in the FAQ section if that's alright.

[galtalmor]

@orrsteinberg anything that isn't complete yet

[owolfy]

I saw some typos and inconsistent translations.
What is the convention for revisions PR?

[galnir]

I saw some typos and inconsistent translations.
What is the convention for revisions PR?

Open a PR with the fixes, nothing special

[galnir]

#280

[gaearon]

Thanks to everyone who worked on the old translation!
I've updated the TODO list for the new one in #280.