Comments (4)
I've found in the past that when I'm bumping up against the time limits of the asynchronous...
family of methods in tests, the solution is typically to attempt to speed up the test rather than increase the duration of the wait.
With respect to adding a new method, I'd learn towards actively discouraging long-running test methods in ReactiveObjC unless there's a very good use case for allowing custom wait durations.
However, if you absolutely need a longer timeout, it should be relatively easy to roll your own asynchronous...
wait method as a RACSignal
extension.
from reactiveobjc.
We are using it for performance testing with quite large data set, so we expect it to be longer then 10, especially on our Jenkins machines that are relatively slow.
But regardless of that I think allowing to pass dependency is generally good idea. Someone maybe needs shorter time interval. And we can still keep default value 10.
from reactiveobjc.
That use case seems like something that could be supported by ReactiveObjC if you'd want to take a stab at it. We'd likely want to keep the original asynchronous...
methods but add another set that takes an extra timeout:(NSTimeInterval)
for backwards compatibility.
from reactiveobjc.
Yes, that makes sense. Cool, I will then work on this when I have some free time and will post PR.
from reactiveobjc.
Related Issues (20)
- RACObserve(target, key) HOT 1
- should I check the existance of weakself before @strongify(self) ? HOT 3
- [RACCommand addActiveExecutionSignal:]crashed HOT 2
- Error: 'ReactiveObjC/EXTKeyPathCoding.h' file not found๏ผ
- why the instruments say that the RAC Memory leaks?
- Why use pods package tools make static frame error ? .podspec is ok? HOT 1
- OSAtomic deprecation in iOS 10.0 HOT 1
- Xcode12 ReactiveObjC archive error HOT 2
- SMP HAVE NO SUPPORT
- 3.1.1 endless loop
- AVPlayerItem was deallocated while key value observers were still registered with it.
- crash in -[NSObject(RACDeallocating) rac_deallocDisposable] NSObject+RACDeallocating.m
- Delay delays cancelled stream completion
- ้ช้ HOT 1
- m1 Can't install 3.1.1 via CocoaPods
- ReactiveObjC (3.1.1) Build Failed
- Get build errors with Xcode 15 HOT 3
- Xcode 15 Release build error "error: unexpected '@' in program @weakify(self); ^" HOT 2
- iOS 17 Crash
- Apple requires third-party SDKs to contain a privacy manifest file HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactiveobjc.