client/templates/layout not on git about reaction

[aferreroc]

If I manually create layout folder it works well.

[aaronjudd]

This is the file, wonder why it's not pulling for you?

https://github.com/ongoworks/reaction/blob/master/packages/reaction-commerce/client/templates/layout/notFound/notfound.html

[aaronjudd]

Are you saying the whole layout folder is missing in local repo? You might have conflicts preventing you from getting all the latest.

[aferreroc]

With a new git clone, also I have all layout folder missing.

[aaronjudd]

I just did:

git clone https://github.com/ongoworks/reaction.git
cd reaction
ls packages/reaction-commerce/client/templates/layout/

All came down successfully for me. Maybe try these steps from a new directory and see what you get?

[aferreroc]

./bin/restart
While building package reaction-commerce:
error: File not found: client/templates/layout/notFound/notFound.html

client/templates/layout => NOT FOUND
packages/reaction-commerce/client/templates/layout/ => Found

If I do: mkdir -p client/templates/layout it works.

[aaronjudd]

Hmm.. it shouldn't be looking for client/templates/layout, should always be looking for packages/reaction-commerce/client/templates/layout/

I'll do some more tests to see if I can replicate

[quangvo55]

The error is thrown is because the file is named notfound.html. I renamed the file to packages/reaction-commerce/client/templates/layout/notFound.html and it worked in building the reaction package.

[aaronjudd]

Good catch. It's interesting, locally I do have notFound - I think when I renamed it the case changed didn't register on the commit.