Coder Social home page Coder Social logo

Comments (7)

zenweasel avatar zenweasel commented on August 18, 2024 2

My .02. I think this is one of the last remnants of Meteor in admin and is probably a good candidate for a GQL query. This should be the standard pattern by now I would think

from reaction-admin.

loan-laux avatar loan-laux commented on August 18, 2024 1

I'm taking on this one if you guys don't mind. Already started to implement the paginated query on api-plugin-email. PRs coming soon.

from reaction-admin.

nnnnat avatar nnnnat commented on August 18, 2024 1

@loan-laux I got you. Someone will get these reviewed hopefully next week. Thank you for helping out here, very much appreciated.

from reaction-admin.

Akarshit avatar Akarshit commented on August 18, 2024

@nnnnat I was looking into ways to solve this. This is what I have so far:
The query fetches all emails and is used by SortableTable, which expects all of the data to be present. This is used for filtering and pagination. If we were to change this, we would have to implement a few things like:

  1. Pagination while fetching the query on the server.
  2. Filtering/search on the server.
  3. Modifying the SortabeTable to handle this new type of stream.

Wanted to get a confirmation if this seems like a good plan to go forward with. Another option is to make it a GQL query and do the same things as above.

from reaction-admin.

nnnnat avatar nnnnat commented on August 18, 2024

Yeah I agree with @zenweasel here. We should try to move this to a GQL query and follow the same pagination/filtering patters we have for things like products and orders (hopefully minimize the amount of modifications to SortableTable). Probably not a small lift but the patterns should exist now @Akarshit if you want to take this on.

from reaction-admin.

loan-laux avatar loan-laux commented on August 18, 2024

Thanks for assigning me, @nnnnat. Can you move this to In Progress on the Bugs & Stability Improvements board? Just to satisfy my PTSD and show some progress on that loading bar. 😄

from reaction-admin.

loan-laux avatar loan-laux commented on August 18, 2024

@nnnnat, feel free to check out my two PRs when you have some time:

reactioncommerce/api-plugin-email#6
#350

from reaction-admin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.