Comments (7)
My .02. I think this is one of the last remnants of Meteor in admin and is probably a good candidate for a GQL query. This should be the standard pattern by now I would think
from reaction-admin.
I'm taking on this one if you guys don't mind. Already started to implement the paginated query on api-plugin-email
. PRs coming soon.
from reaction-admin.
@loan-laux I got you. Someone will get these reviewed hopefully next week. Thank you for helping out here, very much appreciated.
from reaction-admin.
@nnnnat I was looking into ways to solve this. This is what I have so far:
The query fetches all emails and is used by SortableTable
, which expects all of the data to be present. This is used for filtering and pagination. If we were to change this, we would have to implement a few things like:
- Pagination while fetching the query on the server.
- Filtering/search on the server.
- Modifying the
SortabeTable
to handle this new type of stream.
Wanted to get a confirmation if this seems like a good plan to go forward with. Another option is to make it a GQL query and do the same things as above.
from reaction-admin.
Yeah I agree with @zenweasel here. We should try to move this to a GQL query and follow the same pagination/filtering patters we have for things like products and orders (hopefully minimize the amount of modifications to SortableTable
). Probably not a small lift but the patterns should exist now @Akarshit if you want to take this on.
from reaction-admin.
Thanks for assigning me, @nnnnat. Can you move this to In Progress
on the Bugs & Stability Improvements
board? Just to satisfy my PTSD and show some progress on that loading bar.
from reaction-admin.
@nnnnat, feel free to check out my two PRs when you have some time:
reactioncommerce/api-plugin-email#6
#350
from reaction-admin.
Related Issues (20)
- Include in Sitemap? Checkbox Not Functional
- When we create a product variant compareAtPrice is mandatory
- Invited shop manager does not have acces to shop HOT 1
- Discount minimum order amount condition is forced to 0
- Order detail page link is broken
- Product can be published and displayed on storefront with only a variant attribute HOT 2
- Add pre-commit hooks for linting commit message
- "Print invoice" link isn't working
- Navigation page doesn't render the navigation tree anymore HOT 14
- Enable docker push only for trunk
- Enable semantic-release of reaction-admin HOT 1
- Product metadata breaking admin panel HOT 1
- `roleCheck` and `hasPermissions` can break the "new product" flow HOT 1
- initApollo.js: WebSocket is closed before the connection is established. HOT 1
- Navigation page errors out HOT 1
- Upgrade to Meteor 2.5 HOT 2
- Storefront navigation using tags gives 404 error HOT 2
- Order has status "new" and primary shop owner can nothing to do with it HOT 2
- Replica set check requires "clusterManager" database role
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reaction-admin.