TypeError: Cannot read property 'makeHref' of undefined about reactgo

[choonkending]

@rhys-edwards Do you have a branch we could take a look at?

Also, try npm install again to make sure we've got the latest react-router. I had this problem before, but I fixed it with the new webpack.config.

[rhys-edwards]

@choonkending no branches to speak of as it was a clean clone. Can re-up it for you to take a look like if you wish?

Gave npm install a go but still being thrown the same error.

[choonkending]

@rhys-edwards Sure! Would be helpful. I will try to reproduce this error if possible.

[rhys-edwards]

@choonkending Something going wrong and I can't make a branch due to an auth issue with Github.

In the meantime, I've done a clean clone from the repo; seems like reactt-router has updated with the below.

remix-run/react-router#1789

This is now throwing an error:

Rhyss-MacBook-Pro:react-webpack-node rhysedwards$ npm run dev

> [email protected] dev /Users/rhysedwards/Desktop/react-webpack-node
> NODE_ENV=development node server/index.js

Environment: development
/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:71
 \"react-router/lib/Location\""); e.code = 'MODULE_NOT_FOUND'; throw e; }()));
                                                                     ^
Error: Cannot find module "react-router/lib/Location"
    at webpackMissingModule (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:71:96)
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:71:198)
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:122:28)
    at __webpack_require__ (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:21:30)
    at /Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:41:18
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/public/assets/app.server.js:44:10)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/rhysedwards/Desktop/react-webpack-node/server/config/routes.js:11:11)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)

npm ERR! Darwin 14.5.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "dev"
npm ERR! node v0.12.7
npm ERR! npm  v2.13.2
npm ERR! code ELIFECYCLE
npm ERR! [email protected] dev: `NODE_ENV=development node server/index.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] dev script 'NODE_ENV=development node server/index.js'.
npm ERR! This is most likely a problem with the react-webpack-node package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     NODE_ENV=development node server/index.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-webpack-node
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/rhysedwards/Desktop/react-webpack-node/npm-debug.log

[davidlygagnon]

I'm also getting the same error on npm run dev with a clean clone of this repo.

[choonkending]

@rhys-edwards @davidlygagnon Thanks for letting me know. Yea since react-router is still in it's beta stages, there might be many changes. I'll try to get a working version up and running for you guys.

[jure]

Just another data point, I have the same issue here.

[haganbt]

+1

[choonkending]

I had this issue as well when react-router beta 4 was released. A temporary fix was to fix it to the beta 3 version 4796bec, until beta4 is sorted :)

Let me know if this does not fix it for you (remember to pull the latest version)

[jure]

Just letting you know, @choonkending, that on a fresh clone, running devHotLoader still produces the above error.

[choonkending]

@rhys-edwards @jure Sorry it took so long to respond. It shouldn't be an issue with the latest master branch now.

You should now be able to run npm run build once. And from there run npm run dev which will start the server + use react-transform-hmr for hot reloading.

Closing this issue but feel free to open a new issue if you find any bugs. Thanks guys!