Comments (9)
Hey Jared!
As for CardStack, yeah there are a handful of old props left over from the NavigationExperimental views that were moved over. For now I think the best approach is to clean them up, and we can revisit adding things in later.
@satya164, could you make sure the flow types and docs are up to date for screenProps
?
from react-navigation.
@ericvicenti screenProps
are typed as {}
since they can hold arbitrary objects. Not sure what I have to change there.
from react-navigation.
As a side note, while reading the docs I got a bit confused by whether screenProps
is the same thing as this.props.navigation
object in each screen, maybe it was just an old name?
from react-navigation.
@coodoo, screenProps
are extra props that will be passed through the navigator into each screen component, in addition to the navigation prop. Could you submit a PR to help clarify the docs?
from react-navigation.
@satya164 screenProps
are not listed in a bunch of places -- for example, I believe that NavigationContainer
should list screenProps
as a thing it accepts
from react-navigation.
@jaredly NavigationContainer
doesn't accept screenProps
- https://github.com/react-community/react-navigation/search?utf8=%E2%9C%93&q=screenProps&type=Code
from react-navigation.
@satya164 I believe that it does
Here's the trail:
from StackNavigator
return createNavigationContainer(createNavigator(router)(props => (
<CardStack
{...props}
headerComponent={headerComponent}
headerMode={headerMode}
mode={mode}
/>
)), containerOptions);
createNavigationContainer
and createNavigator
both spread in all props.
And then CardStack
accepts screenProps
.
TLDR I had to read a ton of source code to realize that I could do
const SomeStack = StackNavigator({
// config
});
<SomeStack
screenProps={/* these will get passed to the screen components */}
/>
Please fix the docs so future users don't have to read all your source code.
from react-navigation.
@ericvicenti Absolutely, will see how to merge all above mentioned details into the docs.
from react-navigation.
Closing as we are now generating prop-types directly from flow
which should make it more up-to-date.
from react-navigation.
Related Issues (20)
- Sometimes duplicate tab bar labels appear in bottom tabs HOT 1
- unmountOnBlur shows white screen randomly when switchint tabs HOT 2
- useHeaderHeight changes several times when orientation changes HOT 3
- Navigate into page, increase RAM, navigate back and RAM stays high HOT 1
- When using frosted glass stack to jump in Android mode, ReactNavigation will experience lag and frosted glass will reset HOT 5
- Weird transition in navigation HOT 2
- Invariant Violation: requireNativeComponent: "RNSModalScreen" was not found in the UIManager. HOT 17
- [Bridgeless] [RN 0.74] Event cannot be both direct and bubbling: topFocus HOT 4
- Strange flicker when you scroll up a modal with NativeStack in iOS
- Ripple effect shown twice after clicking one time on material top tab after new architecture enabled. HOT 5
- onStateChange called after screen's mount (useEffect) HOT 6
- MaterialTopTabNavigator Icon Layout Shifting HOT 4
- To prevent the default behavior using e.preventDefault() on `tabPress` event is no longer working HOT 4
- RemoveEventListener error in react-native-navigation@4 HOT 7
- Keyboard is dismissed immediately when focusing on TextInput field on non-outer tabs for `react-native-tab-view` HOT 1
- RemoveEventListener error in react-native-navigation@4 HOT 8
- Bottom Tabs flash when opening keyboard HOT 2
- Bottom Tab Navigator falls out of viewable area HOT 2
- Wrong header height value for screens inside Native Stack inside another Native Stack with modal presentation on iOS
- headerLargeTitle: true with headerBackTitleVisible: false makes back button animation jerky HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-navigation.